From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, Peter Geoghegan <pg@bowt.ie>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: buildfarm: could not read block 3 in file "base/16384/2662": read
 only 0 of 8192 bytes
In-reply-to: <14220.1536176805@sss.pgh.pa.us>
References: <20180828075213.yqyl3w2gpd5heopd@alap3.anarazel.de>
 <20180829025658.brk3hfdczo3f73al@alap3.anarazel.de>
 <6970.1535512705@sss.pgh.pa.us>
 <20180829032714.6yu3bxdywcvyj2li@alap3.anarazel.de>
 <20180829032908.o46wdjmti6c6dfep@alap3.anarazel.de>
 <20180829083730.n645apqhb2gyih3g@alap3.anarazel.de>
 <17825.1535556627@sss.pgh.pa.us> <25024.1535579899@sss.pgh.pa.us>
 <20180831221331.3l22nwxrokqeujav@alap3.anarazel.de>
 <14904.1535759623@sss.pgh.pa.us>
 <20180901002101.ph6cngswhqfmpaeh@alap3.anarazel.de>
 <30649.1535813665@sss.pgh.pa.us> <14220.1536176805@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 05 Sep 2018 15:46:45 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21572.1536269918.1@sss.pgh.pa.us>
Date: Thu, 06 Sep 2018 17:38:38 -0400
Message-ID: <21573.1536269918@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> So where are we on this?  Should I proceed with my patch, or are we
> going to do further investigation?  Does anyone want to do an actual
> patch review?

[ crickets... ]

So I took that as license to proceed, but while doing a final round of
testing I found out that a CLOBBER_CACHE_RECURSIVELY build fails,
because now that's an infinite recursion.  On reflection it's a bit
surprising that it wasn't so all along.  What I'm inclined to do about
it is to adjust AcceptInvalidationMessages so that there's a finite
recursion depth limit in the CLOBBER_CACHE_RECURSIVELY case, as there
already is in the CLOBBER_CACHE_ALWAYS case.  Maybe 3 or so levels
would be enough.

			regards, tom lane