Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1db8Eg-0008Mm-3j for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Jul 2017 16:35:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1db8Ef-0005a5-K1 for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Jul 2017 16:35:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1db8Ee-0005Zv-V9 for pgsql-hackers@postgresql.org; Fri, 28 Jul 2017 16:35:33 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1db8Eb-0004U6-6d for pgsql-hackers@postgresql.org; Fri, 28 Jul 2017 16:35:32 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v6SGZM8D021579; Fri, 28 Jul 2017 12:35:22 -0400 From: Tom Lane To: Ashutosh Sharma cc: Andrew Dunstan , Robert Haas , Dave Page , Sandeep Thakkar , "pgsql-hackers@postgresql.org" Subject: Re: pl/perl extension fails on Windows In-reply-to: References: <184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com> <16093.1499956602@sss.pgh.pa.us> <7480.1499965218@sss.pgh.pa.us> <30585.1500480763@sss.pgh.pa.us> <32468.1500498091@sss.pgh.pa.us> <20729.1501039314@sss.pgh.pa.us> <22864.1501165302@sss.pgh.pa.us> <29418.1501187612@sss.pgh.pa.us> <03b6bc63-93d9-59c5-6e56-822bee04f739@2ndQuadrant.com> <25190.1501249960@sss.pgh.pa.us> Comments: In-reply-to Ashutosh Sharma message dated "Fri, 28 Jul 2017 21:46:41 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <21577.1501259722.1@sss.pgh.pa.us> Date: Fri, 28 Jul 2017 12:35:22 -0400 Message-ID: <21578.1501259722@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Ashutosh Sharma writes: > On Fri, Jul 28, 2017 at 7:22 PM, Tom Lane wrote: >> Assuming that the Perl crew know what they're doing and this list is >> complete, I notice that not one of the symbols they show as relevant >> starts with an underscore. So I'm thinking that my previous semi- >> joking idea of absorbing only -D switches for names that *don't* >> start with an underscore was actually a good solution. > Okay, as per your suggestion, I have modified my earlier patches that > imports the -D switches used by perl into plperl accordingly i.e. it > now ignores the switches whose name starts with underscore. Please > find plperl_win_v3 and plperl_linux_v2 patches attached with this > email. OK, thanks. I've pushed the XSUB/dTHX patch after another round of code-reading and some minor comment improvements; we'll soon see what the buildfarm thinks of it. In the meantime I'll work on these two patches. >> (BTW, you never did tell us exactly what defines you're getting >> out of Perl's flags on the problem installation.) > I am really sorry about that. I just missed that in my earlier email. > Here are the defines used in the perl where i could reproduce the > issue, > C:\Users\ashu>perl -MConfig -e "print $Config{ccflags}" > -nologo -GF -W3 -O1 -MD -Zi -DNDEBUG -GL -fp:precise -DWIN32 > -D_CONSOLE -DNO_STRICT -DWIN64 -DCONSERVATIVE -DUSE_SITECUSTOMIZE > -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS Uh-huh. So the issue is indeed that they're injecting PERL_IMPLICIT_SYS via a command-line #define rather than putting it into perl's config.h, and that results in a change in the apparent size of the PerlInterp struct (because of IMem and friends). We'd expected as much, but it's good to have clear confirmation. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers