Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1us0OG-00G03D-8s
	for pgsql-hackers@arkaria.postgresql.org; Fri, 29 Aug 2025 14:47:45 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1us0OF-00AYAN-EN
	for pgsql-hackers@arkaria.postgresql.org; Fri, 29 Aug 2025 14:47:44 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1us0OF-00AYA9-53
	for pgsql-hackers@lists.postgresql.org; Fri, 29 Aug 2025 14:47:43 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1us0OD-002Nku-1V
	for pgsql-hackers@lists.postgresql.org;
	Fri, 29 Aug 2025 14:47:42 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 57TEldRU2159708;
	Fri, 29 Aug 2025 10:47:39 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: headerscheck warnings with late-model gcc
In-reply-to: <5101ab7b-e38b-4c56-b8b1-38655a5ecd6a@eisentraut.org>
References: <1127775.1754417387@sss.pgh.pa.us>
 <9b7ef918-302e-4c84-bc04-a37f5c2b5f92@eisentraut.org>
 <1440669.1754507496@sss.pgh.pa.us>
 <331f9ea7-8ddc-40c6-8a36-3e8994d3d3b3@eisentraut.org>
 <1571545.1754578736@sss.pgh.pa.us>
 <5101ab7b-e38b-4c56-b8b1-38655a5ecd6a@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Fri, 29 Aug 2025 09:37:36 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2159706.1756478859.1@sss.pgh.pa.us>
Date: Fri, 29 Aug 2025 10:47:39 -0400
Message-ID: <2159707.1756478859@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2159707.1756478859%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> On 07.08.25 16:58, Tom Lane wrote:
>> 0004: I prefer the solution I exhibited yesterday, ie add
>> externs to those headers.

> That solution seems fine, too.

Great.

> This comment should be clarified:
> +	# This redundant extern declaration is needed to silence headerscheck
> +	# warnings with some gcc versions.
> You could just write
> # silence -Wmissing-variable-declarations
> which also appears elsewhere in the code.

I compromised on writing "redundant declaration to silence
-Wmissing-variable-declarations", and pushed it.

			regards, tom lane