Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lw4EC-0001Rf-GS for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Jun 2021 14:51:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lw4EB-0000V9-Dj for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Jun 2021 14:51:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lw4EB-0000V1-60 for pgsql-hackers@lists.postgresql.org; Wed, 23 Jun 2021 14:51:43 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lw4E6-0007ry-6O for pgsql-hackers@lists.postgresql.org; Wed, 23 Jun 2021 14:51:42 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 15NEpV8o2161206; Wed, 23 Jun 2021 10:51:31 -0400 From: Tom Lane To: Tomas Vondra cc: Amit Kapila , Amit Langote , Dilip Kumar , osumi.takamichi@fujitsu.com, Alvaro Herrera , Andres Freund , Ashutosh Bapat , Peter Eisentraut , Petr Jelinek , PostgreSQL Hackers Subject: Re: Decoding speculative insert with toast leaks memory In-reply-to: <7dab0929-a966-0c0a-4726-878fced2fe00@enterprisedb.com> References: <648020.1623854904@sss.pgh.pa.us> <7dab0929-a966-0c0a-4726-878fced2fe00@enterpri! sedb.com> Comments: In-reply-to Tomas Vondra message dated "Wed, 23 Jun 2021 16:43:44 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2161204.1624459891.1@sss.pgh.pa.us> Date: Wed, 23 Jun 2021 10:51:31 -0400 Message-ID: <2161205.1624459891@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Tomas Vondra writes: > While rebasing a patch broken by 4daa140a2f5, I noticed that the patch > does this: > @@ -63,6 +63,7 @@ enum ReorderBufferChangeType > REORDER_BUFFER_CHANGE_INTERNAL_TUPLECID, > REORDER_BUFFER_CHANGE_INTERNAL_SPEC_INSERT, > REORDER_BUFFER_CHANGE_INTERNAL_SPEC_CONFIRM, > + REORDER_BUFFER_CHANGE_INTERNAL_SPEC_ABORT, > REORDER_BUFFER_CHANGE_TRUNCATE > }; > Isn't that an undesirable ABI break for extensions? I think it's OK in HEAD. I agree we shouldn't do it like that in the back branches. regards, tom lane