Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M315536=pgsql-hackers-arkari@postgresql.org>)
	id 1cVfXO-0007pi-O3
	for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jan 2017 14:24:02 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M315536=pgsql-hackers-arkari@postgresql.org>)
	id 1cVfXO-0004Mz-BG
	for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jan 2017 14:24:02 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1cVfVy-0001DI-29
	for pgsql-hackers@postgresql.org; Mon, 23 Jan 2017 14:22:34 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1cVfVv-0000OD-5n
	for pgsql-hackers@postgresql.org; Mon, 23 Jan 2017 14:22:33 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v0NEMSpJ021625;
	Mon, 23 Jan 2017 09:22:28 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: Pavan Deolasee <pavan.deolasee@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Failure in commit_ts tap tests
In-reply-to: <644bd551-33c0-13bf-ba04-415a39367d6a@2ndQuadrant.com>
References: 
 <CABOikdPhsHM+pX8skoEY1_T0OtKdO1udzUj4VCjU5VEt+bj4eA@mail.gmail.com>
 <19348.1484936537@sss.pgh.pa.us>
 <24cf2b76-9b9f-bba9-7e8b-89b9d0ba2471@2ndQuadrant.com>
 <17741.1485180194@sss.pgh.pa.us>
 <644bd551-33c0-13bf-ba04-415a39367d6a@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Mon, 23 Jan 2017 09:20:28 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21623.1485181348.1@sss.pgh.pa.us>
Date: Mon, 23 Jan 2017 09:22:28 -0500
Message-ID: <21624.1485181348@sss.pgh.pa.us>
X-Pg-Spam-Score: -5.1 (-----)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 01/23/2017 09:03 AM, Tom Lane wrote:
>> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>>> On 01/20/2017 01:22 PM, Tom Lane wrote:
>>>> It looks like at least part of the answer is that the buildfarm isn't
>>>> running this test.  AFAICS, it runs "make installcheck" not
>>>> "make check" in src/test/modules.

> OK, so should we just change "make installcheck" to "make check"?

I'm in favor (just for src/test/modules, to be clear).

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers