public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Andreas Karlsson <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: btree_gist into core?
Date: Mon, 24 Jan 2022 18:29:24 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

Andreas Karlsson <[email protected]> writes:
> On 1/19/22 09:30, Peter Eisentraut wrote:
>> I don't have a lot of experience with this module, so I don't know if 
>> there are any lingering concerns about whether it is mature enough as a 
>> built-in feature.

> While it I like the idea on a conceptual level I worry about the code 
> quality of the module. I know that the btree/cidr code is pretty broken. 
> But I am not sure if there are any issues with other data types.

Yeah :-(.  We just fixed an issue with its char(n) support too
(54b1cb7eb), so I don't have a terribly warm feeling about the
quality of the lesser-used code paths.  Still, maybe we could
do some code review/testing rather than a blind copy & paste.

I'd also opine that we don't have to preserve on-disk compatibility
while migrating into core, which'd help get out of the sticky problem
for inet/cidr.  This'd require being able to run the contrib module
alongside the core version for awhile (to support existing indexes),
but I think we could manage that if we tried.  IIRC we did something
similar when we migrated tsearch into core.

One thing I don't know anything about is how good are btree_gist
indexes performance-wise.  Do they have problems that we'd really
need to fix to consider them core-quality?

			regards, tom lane

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: btree_gist into core?
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox