From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marina Polyakova <m.polyakova@postgrespro.ru>
cc: pgsql-hackers@postgresql.org, Noah Misch <noah@leadboat.com>,
        exclusion@gmail.com
Subject: Re: Conflict between regression tests namespace & transactions due to
 recent changes
In-reply-to: <80d0201636665d82185942e7112257b4@postgrespro.ru>
References: <80d0201636665d82185942e7112257b4@postgrespro.ru>
Comments: In-reply-to Marina Polyakova <m.polyakova@postgrespro.ru>
	message dated "Mon, 15 May 2023 18:27:29 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2165311.1684167368.1@sss.pgh.pa.us>
Date: Mon, 15 May 2023 12:16:08 -0400
Message-ID: <2165312.1684167368@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2165312.1684167368%40sss.pgh.pa.us>
Precedence: bulk

Marina Polyakova <m.polyakova@postgrespro.ru> writes:
> IIUC the conflict was caused by

> +SET search_path to public, test_ns_schema_1;
> +CREATE SCHEMA test_ns_schema_2
> +       CREATE VIEW abc_view AS SELECT a FROM abc;

> because the parallel regression test transactions had already created 
> the table abc and was trying to drop it.

Hmm.  I'd actually fix the blame on transactions.sql here.  Creating
a table named as generically as "abc" is horribly bad practice in
a set of concurrent tests.  namespace.sql is arguably okay, since
it's creating that table name in a private schema.

I'd be inclined to fix this by doing s/abc/something-else/g in
transactions.sql.

			regards, tom lane