From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@enterprisedb.com>
cc: Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>,
        Justin Pryzby <pryzby@telsasoft.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Re: windows cfbot failing: my_perl
In-reply-to: 
 <CAFBsxsGYrjEyt+taR1et9bpK6PJeVMAm2dwNR52Gpd84aZ2rHA@mail.gmail.com>
References: <20220826115546.GE2342@telsasoft.com>
 <20220826132151.sj6pieswskq4vp4z@awork3.anarazel.de>
 <20220826134047.vr3bppkwqhy5ppn3@awork3.anarazel.de>
 <20220826142700.fecymkdgdelktrlp@awork3.anarazel.de>
 <CAFBsxsFew_-eaa6geJsR5WcRLeQ9afrPg4rZL59g=3GGu5g_+Q@mail.gmail.com>
 <20220826144740.ff3berqoeoi6lnd4@awork3.anarazel.de>
 <213a7840-f3eb-e294-7d9a-9602d833dad7@dunslane.net>
 <20220826211507.vaepb2nzlh3krxdg@awork3.anarazel.de>
 <CAFBsxsGYrjEyt+taR1et9bpK6PJeVMAm2dwNR52Gpd84aZ2rHA@mail.gmail.com>
Comments: In-reply-to John Naylor <john.naylor@enterprisedb.com>
	message dated "Sat, 27 Aug 2022 09:32:45 +0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2167246.1661569326.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 26 Aug 2022 23:02:06 -0400
Message-ID: <2167247.1661569326@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2167247.1661569326%40sss.pgh.pa.us>
Precedence: bulk

John Naylor <john.naylor@enterprisedb.com> writes:
> On Sat, Aug 27, 2022 at 4:15 AM Andres Freund <andres@anarazel.de> wrote=
:
>> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting=
 the
>> include in plperl.h would keep that aspect transparent, because plperl_=
utils.h
>> includes plperl.h.

> Since plperl_helpers.h already includes plperl.h, I'm not sure why
> both are included everywhere the former is. If .c/.xs files didn't
> include plperl.h directly, we could keep pg_wchar.h in
> plperl_helpers.h. Not sure if that's workable or any better...

Maybe we should flush the separate plperl_helpers.h header and just
put those static-inline functions in plperl.h.

			regards, tom lane