Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klEds-00055c-EM for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Dec 2020 17:13:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1klEdr-0002Zn-Dt for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Dec 2020 17:13:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klEdr-0002Ze-72 for pgsql-hackers@lists.postgresql.org; Fri, 04 Dec 2020 17:13:11 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klEdp-0000r9-3s; Fri, 04 Dec 2020 17:13:10 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 0B4HD5es2168111; Fri, 4 Dec 2020 12:13:05 -0500 From: Tom Lane To: Justin Pryzby cc: Alvaro Herrera , David Rowley , pgsql-hackers@lists.postgresql.org Subject: Re: pg_dump, ATTACH, and independently restorable child partitions In-reply-to: <20201202225013.GJ24052@telsasoft.com> References: <20201024195949.GL9241@telsasoft.com> <20201107021835.GA13348@alvherre.pgsql> <20201120152055.GF24784@telsasoft.com> <577158.1606347319@sss.pgh.pa.us> <20201202225013.GJ24052@telsasoft.com> Comments: In-reply-to Justin Pryzby message dated "Wed, 02 Dec 2020 16:50:13 -0600" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <2168109.1607101985.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 04 Dec 2020 12:13:05 -0500 Message-ID: <2168110.1607101985@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Justin Pryzby writes: > [ v4-0001-pg_dump-output-separate-object-for-ALTER-TABLE.AT.patch ] The cfbot is being picky about this: 3218pg_dump.c: In function =E2=80=98dumpTableAttach=E2=80=99: 3219pg_dump.c:15600:42: error: suggest parentheses around comparison in op= erand of =E2=80=98&=E2=80=99 [-Werror=3Dparentheses] 3220 if (attachinfo->partitionTbl->dobj.dump & DUMP_COMPONENT_DEFINITION = =3D=3D 0) 3221 ^ 3222cc1: all warnings being treated as errors which if I've got the precedence straight is indeed a bug. Personally I'd probably write if (!(attachinfo->partitionTbl->dobj.dump & DUMP_COMPONENT_DEFINITION)= ) as it seems like a boolean test to me. regards, tom lane