Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M339372=pgsql-hackers-arkari@postgresql.org>)
	id 1eCpaC-0002IL-HI
	for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Nov 2017 16:21:36 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M339372=pgsql-hackers-arkari@postgresql.org>)
	id 1eCpaC-0004tP-4G
	for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Nov 2017 16:21:36 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eCpaA-0004jf-0t
	for pgsql-hackers@postgresql.org; Thu, 09 Nov 2017 16:21:34 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eCpa7-0000Zx-9a
	for pgsql-hackers@postgresql.org; Thu, 09 Nov 2017 16:21:32 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id vA9GLQxQ021765;
	Thu, 9 Nov 2017 11:21:26 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: a.akenteva@postgrespro.ru, pgsql-hackers@postgresql.org
Subject: Re: A weird bit in pg_upgrade/exec.c
In-reply-to: <20171109160608.ix24ajduhlzeiz44@alvherre.pgsql>
References: <20171109160608.ix24ajduhlzeiz44@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Thu, 09 Nov 2017 17:06:08 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21763.1510244486.1@sss.pgh.pa.us>
Date: Thu, 09 Nov 2017 11:21:26 -0500
Message-ID: <21764.1510244486@sss.pgh.pa.us>
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I think odd coding this was introduced recently because of the
> pg_resetxlog -> pg_resetwal renaming.

Dunno about that, but certainly somebody fat-fingered a refactoring
there.  The 9.6 code looks quite different but doesn't seem to be
doing anything silly.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers