Feedback-ID: i131946ab:Fastmail
Content-Type: multipart/mixed; boundary="------------xkMdhSoPRR0Spk9KP2DntZEU"
Message-ID: <2180a97c-c026-1b6c-cec8-d6e499f97017@enterprisedb.com>
Date: Wed, 31 Aug 2022 10:28:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.0
Subject: Re: [RFC] building postgres with meson - v12
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Cc: samay sharma <smilingsamay@gmail.com>,
 Nazir Bilal Yavuz <byavuz81@gmail.com>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
 <20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/2180a97c-c026-1b6c-cec8-d6e499f97017%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------xkMdhSoPRR0Spk9KP2DntZEU
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

I found that the perl test modules are not installed.  See attached 
patch to correct this.

To the patches:

4e15ee0e24 Don't hardcode tmp_check/ as test directory for tap tests
1a3169bc3f Split TESTDIR into TESTLOGDIR and TESTDATADIR

It's a bit weird that the first patch changes the meaning of TESTDIR
and the second patch removes it.  Maybe these patches should be
squashed together?


96d1d0a0cf meson: prereq: Extend gendef.pl in preparation for meson

ok


581721fa99 meson: prereq: Add src/tools/gen_export.pl

Still wondering about the whitespace changes I reported recently, but
that can also be fine-tuned later.


4245cc888e meson: prereq: Refactor PG_TEST_EXTRA logic in autoconf build

ok


3afe803e0f meson: prereq: Fix warning compat_informix/rnull.pgc with msvc

ok


ae7733f46c meson: prereq: Move darwin sysroot determination into 
separate file

ok


a1fb97a81b meson: Add meson based buildsystem

I'm not a fan of all this business to protect the two build systems
from each other.  I don't like the build process touching a file under
version control every time.  How necessary is this?  What happens
otherwise?

conversion_helpers.txt: should probably be removed now.

doc/src/sgml/resolv.xsl: I don't understand what this is doing.  Maybe
at least add a comment in the file.

src/common/unicode/meson.build: The comment at the top of the file
should be moved next to the files it is describing (similar to how it
is in the makefile).  I don't see CLDR_VERSION set anywhere.  Is that
part implemented?

src/port/win32ver.rc.in: This is redundant with src/port/win32ver.rc.
(Note that the latter is also used as an input file for text
substitution.  So having another file named *.in next to it would be
super confusing.)

src/tools/find_meson: Could use a brief comment what it does.

src/tools/pgflex: Could use a not-brief comment about what it does,
why it's needed.  Also a comment where it's used.  Also run this
through pycodestyle.

src/tools/rcgen: This is connected with the comment on win32ver.rc.in
above.  We already have this equivalent code in
src/makefiles/Makefile.win32.  Let's figure out a way to share this
code.  (It could be a Perl script, which is already required on
Windows.)  Also pycodestyle.

src/tools/testwrap: also documentation/comments/pycodestyle


cd193eb3e8 meson: ci: Build both with meson and as before

I haven't reviewed this one in detail.  Maybe add a summary in the
commit message, like these are the new jobs, these are the changes to
existing jobs.  It looks like there is more in there than just adding
a few meson jobs.


If the above are addressed, I think this will be just about at the
point where the above patches can be committed.

Everything past these patches I'm mentally postponing right now.
--------------xkMdhSoPRR0Spk9KP2DntZEU
Content-Type: text/plain; charset=UTF-8;
 name="0001-meson-Install-test-perl-modules.patch"
Content-Disposition: attachment;
 filename="0001-meson-Install-test-perl-modules.patch"
Content-Transfer-Encoding: base64

RnJvbSA4MGQ2ZjRmOWE1NzRkZGI2MjUwZTA2NDkwYzYxMDk2OWFhY2RiODI0IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogV2VkLCAzMSBBdWcgMjAyMiAwOToxNjowNCArMDIwMApTdWJqZWN0
OiBbUEFUQ0hdIG1lc29uOiBJbnN0YWxsIHRlc3QgcGVybCBtb2R1bGVzCgotLS0KIHNyYy90
ZXN0L21lc29uLmJ1aWxkICAgICAgfCAgMiArKwogc3JjL3Rlc3QvcGVybC9tZXNvbi5idWls
ZCB8IDEyICsrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCsp
CiBjcmVhdGUgbW9kZSAxMDA2NDQgc3JjL3Rlc3QvcGVybC9tZXNvbi5idWlsZAoKZGlmZiAt
LWdpdCBhL3NyYy90ZXN0L21lc29uLmJ1aWxkIGIvc3JjL3Rlc3QvbWVzb24uYnVpbGQKaW5k
ZXggYjg2YTBmMzg4OS4uMjQxZDlkNDhhYSAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvbWVzb24u
YnVpbGQKKysrIGIvc3JjL3Rlc3QvbWVzb24uYnVpbGQKQEAgLTIxLDMgKzIxLDUgQEAgZW5k
aWYKIGlmIGljdS5mb3VuZCgpCiAgIHN1YmRpcignaWN1JykKIGVuZGlmCisKK3N1YmRpcign
cGVybCcpCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9wZXJsL21lc29uLmJ1aWxkIGIvc3JjL3Rl
c3QvcGVybC9tZXNvbi5idWlsZApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw
MDAwLi45MDFiYWU3YTU2Ci0tLSAvZGV2L251bGwKKysrIGIvc3JjL3Rlc3QvcGVybC9tZXNv
bi5idWlsZApAQCAtMCwwICsxLDEyIEBACisjIGNvdWxkIHVzZSBpbnN0YWxsX2RhdGEncyBw
cmVzZXJ2ZV9wYXRoIG9wdGlvbiBpbiA+PTAuNjQuMAorCitpbnN0YWxsX2RhdGEoCisgICdQ
b3N0Z3JlU1FML1ZlcnNpb24ucG0nLAorICBpbnN0YWxsX2RpcjogZGlyX3BneHMgLyAnc3Jj
L3Rlc3QvcGVybC9Qb3N0Z3JlU1FMJykKKworaW5zdGFsbF9kYXRhKAorICAnUG9zdGdyZVNR
TC9UZXN0L1V0aWxzLnBtJywKKyAgJ1Bvc3RncmVTUUwvVGVzdC9TaW1wbGVUZWUucG0nLAor
ICAnUG9zdGdyZVNRTC9UZXN0L1JlY3Vyc2l2ZUNvcHkucG0nLAorICAnUG9zdGdyZVNRTC9U
ZXN0L0NsdXN0ZXIucG0nLAorICBpbnN0YWxsX2RpcjogZGlyX3BneHMgLyAnc3JjL3Rlc3Qv
cGVybC9Qb3N0Z3JlU1FML1Rlc3QnKQotLSAKMi4zNy4xCgo=

--------------xkMdhSoPRR0Spk9KP2DntZEU--