From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
cc: Thomas Munro <thomas.munro@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
        Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
        Robert Haas <robertmhaas@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: AIX support - alignment issues
In-reply-to: <7890936c-392b-91be-edac-b6d5a500e4b9@enterprisedb.com>
References: <20220702183354.a6uhja35wta7agew@alap3.anarazel.de>
 <CAH2-WzndKXQQGh-7sCOTKL_87Kt918r0F2ztTAraeBCAC8v3OQ@mail.gmail.com>
 <968410.1656789743@sss.pgh.pa.us>
 <CAH2-WzmnoGPN--Z7MfTqv2TTVLJF0Y0tzZbGUS-NAwJ0wv15hw@mail.gmail.com>
 <977853.1656794075@sss.pgh.pa.us>
 <CA+hUKGLo8XVq4c=QpXFO5i3t3u5q6Fope=QgRtE-S3RncP+aUg@mail.gmail.com>
 <1415825.1656893299@sss.pgh.pa.us>
 <CA+hUKGJg5kg7LSeKZm1cDFQCTLBWUF1wvuM4eebJBq9DwYfZYw@mail.gmail.com>
 <1827177.1656996797@sss.pgh.pa.us>
 <CA+hUKGJzapRb3UwJF-bLsv=-p6WLk4_hs6WxR8y9LFTSdJBOCw@mail.gmail.com>
 <7890936c-392b-91be-edac-b6d5a500e4b9@enterprisedb.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@enterprisedb.com>
	message dated "Wed, 06 Jul 2022 15:02:15 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2186602.1657116060.1@sss.pgh.pa.us>
Date: Wed, 06 Jul 2022 10:01:00 -0400
Message-ID: <2186603.1657116060@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2186603.1657116060%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 06.07.22 04:21, Thomas Munro wrote:
>> /*
>> * Do not try to collapse these into one "w+" mode file. Doesn't work on
>> -	 * some platforms (eg, HPUX 10.20).
>> +	 * some platforms.
>> */
>> termin = fopen("/dev/tty", "r");
>> termout = fopen("/dev/tty", "w");

> I don't know how /dev/tty behaves in detail under stdio.  I think 
> removing this part of the comment might leave the impression that 
> attempting to use "w+" will never work, whereas the existing comment 
> appears to indicate that it was only very old platforms that had the 
> issue.  If we don't have an immediate answer to that, I'd leave the 
> comment as is.

Yeah, I was kind of wondering whether we should give w+ a try now.
IIRC, the code was like that at one point, but we had to change it
(ie the comment comes from bitter experience).  On the other hand,
it's probably not worth the trouble and risk to change it again.

			regards, tom lane