From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: Nathan Bossart <nathandbossart@gmail.com>,
        =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
        vignesh C <vignesh21@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: Adding a pg_get_owned_sequence function?
In-reply-to: <bc0ddf01-d54f-4a9b-9cf9-a3bf02731fde@eisentraut.org>
References: <87jzwcsasv.fsf@wibble.ilmari.org> <4970adf1-cdb0-9ae5-d405-e9c3395d9931@eisentraut.org> <2797313.1694529622@sss.pgh.pa.us> <87v8cfo32v.fsf@wibble.ilmari.org> <20231024162929.GA871220@nathanxps13> <CALDaNm0_nn-LXSJCXQ6EYiGKjVO8fVO8AemgEVZFQPPdx0=fkg@mail.gmail.com> <87a5pfn4o5.fsf@wibble.ilmari.org> <20240108210847.GA2796792@nathanxps13> <bc0ddf01-d54f-4a9b-9cf9-a3bf02731fde@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Tue, 09 Jan 2024 17:41:14 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2196398.1704819786.1@sss.pgh.pa.us>
Date: Tue, 09 Jan 2024 12:03:06 -0500
Message-ID: <2196399.1704819786@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2196399.1704819786%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> Would it work to change the signature of pg_get_serial_sequence to
>      pg_get_serial_sequence(table anyelement, column text) -> anyelement
> and then check inside the function code whether text or regclass was passed?

Probably not very well, because then we'd get no automatic coercion of
inputs that were not either type.

Maybe it would work to have both

pg_get_serial_sequence(table text, column text) -> text
pg_get_serial_sequence(table regclass, column text) -> regclass

but I wonder if that would create any situations where the parser
couldn't choose between these candidates.

			regards, tom lane