Subject: Re: valgrind issues on Fedora 28
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
 Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
 pgsql-hackers@lists.postgresql.org
References: <20181106173527.omm63tiaguxft7mg@alvherre.pgsql>
 <f6577fe9-def2-7614-958f-9a8fb810f666@2ndquadrant.com>
 <23c8e539-6777-1793-0939-12e73cb98314@2ndquadrant.com>
 <9063c043-83cd-b439-a928-622a743edd2c@2ndquadrant.com>
 <16353.1544760625@sss.pgh.pa.us>
 <4721dbaf-b922-9e30-e635-00f06512edac@2ndquadrant.com>
 <11849.1544803095@sss.pgh.pa.us>
 <25de4d8b-2192-20f0-7d30-6c5b79ddf716@2ndquadrant.com>
 <89ca0db3-1b1a-4188-35a7-0dd7a409e0d5@2ndQuadrant.com>
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Message-ID: <21c39c42-061d-e31e-143b-ccda1a19f8e1@2ndquadrant.com>
Date: Tue, 8 Jan 2019 00:54:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <89ca0db3-1b1a-4188-35a7-0dd7a409e0d5@2ndQuadrant.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/15/18 12:32 AM, Andrew Dunstan wrote:
> 
> On 12/14/18 4:35 PM, Tomas Vondra wrote:
>> On 12/14/18 4:58 PM, Tom Lane wrote:
>>> ...
>>>
>>> In general, I'm not particularly on board with our valgrind.supp
>>> carrying suppressions for code outside our own code base: I think
>>> that's assuming WAY too much about which version of what is installed
>>> on a particular box.
>>>
>> Fair point.
>>
>>> Maybe we could do something to make it simpler to have custom
>>> suppressions?  Not sure what, though.
>>>
>> I was thinking that perhaps we could allows specifying path to extra
>> suppressions and pass that to valgrind.
>>
>> But we don't actually invoke valgrind, that's something people do on
>> their own anyway - so we don't have anywhere to pass the path to. And
>> whoever invokes valgrind can simply stick it directly into the command
>> they're using (as it allows specifying multiple --suppressions=<file>
>> options). Or perhaps just put it into ~/.valgrindrc.
>>
>> So perhaps we should simply revert that commit and be done with it.
>>
>> One place that will need to solve it is buildfarm client, but it could
>> pick either of the options I mentioned.
>>
>>
> 
> The buildfarm client has a parameter in the config file for valgrind
> options. All you would have to do is an an extra --suppressions setting
> in there.
> 

OK, makes sense. I'll revert the commit tomorrow.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services