Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1u5R2j-000EsE-HR
	for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Apr 2025 15:20:45 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1u5R2h-00AdY1-Gr
	for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Apr 2025 15:20:44 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1u5R2h-00AdWS-7C
	for pgsql-hackers@lists.postgresql.org; Thu, 17 Apr 2025 15:20:44 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1u5R2e-000adr-2I
	for pgsql-hackers@lists.postgresql.org;
	Thu, 17 Apr 2025 15:20:43 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 53HFKX5t2202327;
	Thu, 17 Apr 2025 11:20:35 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Jacob Champion <jacob.champion@enterprisedb.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: jsonapi: scary new warnings with LTO enabled
In-reply-to: <0A596D8B-24F3-408F-B89B-B42014B00A05@yesql.se>
References: <2074634.1744839761@sss.pgh.pa.us> <0A3CF5C4-9947-42E3-89A9-34FCF7BA95BA@yesql.se> <2078511.1744841564@sss.pgh.pa.us> <DCD56158-A642-4954-87FF-9DAD5425F3FF@yesql.se> <2084687.1744844690@sss.pgh.pa.us> <CAOYmi+n+DHpaEV5hymhufutTgc+S=+pDQfXEUi4hMAV1eO8aTw@mail.gmail.com> <2087556.1744846124@sss.pgh.pa.us> <0A596D8B-24F3-408F-B89B-B42014B00A05@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Thu, 17 Apr 2025 13:43:18 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2202325.1744903233.1@sss.pgh.pa.us>
Date: Thu, 17 Apr 2025 11:20:33 -0400
Message-ID: <2202326.1744903233@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/2202326.1744903233%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> Agreed, moving to heap allocated structures for these callsites seem much
> better. Something like the attached should be enough I think?

I confirm this silences those warnings on my Fedora 41 box.

I'm content to do it like this, but maybe Jacob wants to
investigate alternatives?

			regards, tom lane