Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1s7jLp-0075P5-CC
	for pgsql-hackers@arkaria.postgresql.org; Thu, 16 May 2024 22:13:26 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1s7jLo-00HEUZ-PV
	for pgsql-hackers@arkaria.postgresql.org; Thu, 16 May 2024 22:13:24 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1s7jLo-00HESb-FY
	for pgsql-hackers@lists.postgresql.org; Thu, 16 May 2024 22:13:24 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1s7jLm-000Z0n-4V
	for pgsql-hackers@postgresql.org; Thu, 16 May 2024 22:13:23 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 44GMDI422206352;
	Thu, 16 May 2024 18:13:18 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: Melanie Plageman <melanieplageman@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: commitfest.postgresql.org is no longer fit for purpose
In-reply-to: <b2b47b25-dbca-4e67-80b2-ced08b6a5e08@eisentraut.org>
References: <CA+TgmobnTcNq1xQE_+jxBEtj+AjKg0r_p5YNFHDE+EDnpcpFxA@mail.gmail.com> <CAAKRu_Yx8utYpBOfmHdqLB64KjEGUsQG8j0ZGNNUS8_8vHbSbw@mail.gmail.com> <45faf826-42b7-4ce9-a081-0903d033f411@eisentraut.org> <2186208.1715895987@sss.pgh.pa.us> <b2b47b25-dbca-4e67-80b2-ced08b6a5e08@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Fri, 17 May 2024 00:03:30 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2206350.1715897598.1@sss.pgh.pa.us>
Date: Thu, 16 May 2024 18:13:18 -0400
Message-ID: <2206351.1715897598@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/2206351.1715897598%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> On 16.05.24 23:46, Tom Lane wrote:
>> Right, so what can we do about that?  Does Needs Review state need to
>> be subdivided, and if so how?

> Maybe a new state "Unclear". ...

> I think, if we consider the core mission of the commitfest app, we need 
> to be more protective of the Needs Review state.

Yeah, makes sense.

> So a third status that encompasses the various other situations like 
> maybe forgotten by author, disagreements between author and reviewer, 
> process difficulties, needs some senior developer intervention, etc. 
> could be helpful.

Hmm, "forgotten by author" seems to generally turn into "this has been
in WOA state a long time".  Not sure we have a problem representing
that, only with a process for eventually retiring such entries.
Your other three examples all sound like "needs senior developer
attention", which could be a helpful state that's distinct from "ready
for committer".  It's definitely not the same as "Unclear".

			regards, tom lane