Feedback-ID: i131946ab:Fastmail
Message-ID: <2214b8bb-d3e2-5978-049b-43eda65a66a2@enterprisedb.com>
Date: Wed, 11 Jan 2023 12:05:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: meson oddities
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <91b563cc-fa78-0011-5efc-ce61d277d64f@dunslane.net>
 <1197537.1668546515@sss.pgh.pa.us>
 <20221115234042.zkxyxzv5wgewit33@awork3.anarazel.de>
 <030d04cc-d4f3-cd28-5bcb-b2b5d00f0015@enterprisedb.com>
 <20221116164010.uxsrhsqiqhftvkfp@awork3.anarazel.de>
 <1360237.1668617650@sss.pgh.pa.us>
 <20221116170747.zpaijt6zz7lgkffd@awork3.anarazel.de>
 <8efbb197-c55a-0947-35ba-6b8403d9baff@enterprisedb.com>
 <20230104193502.ax5gmgt6yqznolvm@awork3.anarazel.de>
 <a6a6de12-f705-2b33-2fd9-9743277deb08@enterprisedb.com>
 <20230104225354.nye62wttsvmicpzw@awork3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20230104225354.nye62wttsvmicpzw@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/2214b8bb-d3e2-5978-049b-43eda65a66a2%40enterprisedb.com>
Precedence: bulk

On 04.01.23 23:53, Andres Freund wrote:
>>   dir_data = get_option('datadir')
>> -if not (dir_data.contains('pgsql') or dir_data.contains('postgres'))
>> +if not ((dir_prefix/dir_data).contains('pgsql') or (dir_prefix/dir_data).contains('postgres'))
>>     dir_data = dir_data / pkg
>>   endif
> Hm. Perhaps we should just test once whether prefix contains pgsql/postgres,
> and then just otherwise leave the test as is? There afaict can't be a
> dir_prefix/dir_* that matches postgres/pgsql that won't also match either of
> the components.

You mean something like

     dir_prefix_contains_pg =
       (dir_prefix.contains('pgsql') or dir_prefix.contains('postgres'))

and

     if not (dir_prefix_contains_pg or
            (dir_data.contains('pgsql') or dir_data.contains('postgres'))

Seems more complicated to me.

I think there is also an adjacent issue:  The subdir options may be 
absolute or relative.  So if you specify --prefix=/usr/local and 
--sysconfdir=/etc/postgresql, then

     config_paths_data.set_quoted('SYSCONFDIR', dir_prefix / dir_sysconf)

would produce something like /usr/local/etc/postgresql.

I think maybe we should make all the dir_* variables absolute right at 
the beginning, like

     dir_lib = get_option('libdir')
     if not fs.is_absolute(dir_lib)
         dir_lib = dir_prefix / dir_lib
     endif

And then the appending stuff could be done after that, keeping the 
current code.