From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
cc: Thomas Munro <thomas.munro@enterprisedb.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Error handling (or lack of it) in RemovePgTempFilesInDir
In-reply-to: 
 <CAB7nPqTdmUUSu9AsrAz4fcFUFNAutw2av3EpHmRi7P7jKFf_bQ@mail.gmail.com>
References: <19907.1512402254@sss.pgh.pa.us>
 <CAEepm=1k1OdQ2LpReSrA1h-NoSgospTQ9Vp4J_RE2aMXwjAS7A@mail.gmail.com>
 <CAB7nPqTdmUUSu9AsrAz4fcFUFNAutw2av3EpHmRi7P7jKFf_bQ@mail.gmail.com>
Comments: In-reply-to Michael Paquier <michael.paquier@gmail.com>
	message dated "Tue, 05 Dec 2017 10:45:27 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <22162.1512438709.1@sss.pgh.pa.us>
Date: Mon, 04 Dec 2017 20:51:49 -0500
Message-ID: <22163.1512438709@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael.paquier@gmail.com> writes:
> On Tue, Dec 5, 2017 at 8:40 AM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> Belatedly, +1.  The error hiding seemed a bit odd considering that we
>> were prepared to log "unexpected file found ...".  I probably should
>> have questioned that instead of extending it monkey-see-monkey-do.

> Well, I am -1 on this change. The coding before commit 561885d that
> you have now pushed (timezone makes me answer later) was way more
> conservative and I honestly preferred it as *only* the next postmaster
> restart would remove remnant temp files which can cause potentially GB
> of data to stay around.

Uh ... I'm confused?  That particular change only concerns whether we emit
a log message, not whether the action is attempted or succeeds.

			regards, tom lane