Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmnrv-000540-Oe for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Aug 2017 21:16:19 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dmnrv-00049B-BB for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Aug 2017 21:16:19 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dmnqM-0000Lf-R1 for pgsql-hackers@postgresql.org; Tue, 29 Aug 2017 21:14:42 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dmnqK-0005UR-5E for pgsql-hackers@postgresql.org; Tue, 29 Aug 2017 21:14:41 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v7TLEVS8022169; Tue, 29 Aug 2017 17:14:32 -0400 From: Tom Lane To: Etsuro Fujita cc: Robert Haas , Jeff Janes , David Steele , Ashutosh Bapat , pgsql-hackers Subject: Re: postgres_fdw bug in 9.6 In-reply-to: References: <0700eb97-d9db-33da-4ba2-e28d2a1631d9@lab.ntt.co.jp> <47f35675-e504-033a-5bbe-185b78b47c3b@pgmasters.net> <23a0e23e-853f-5937-a5fd-84e6c869be92@lab.ntt.co.jp> <79b98e30-4d38-7deb-f1fb-bc0bc589a958@lab.ntt.co.jp> <6a546fa4-6e86-a5ef-8264-cb44d21ff8b6@lab.ntt.co.jp> <97fd423c-b9b2-4e14-71b3-f48693bb5c04@lab.ntt.co.jp> Comments: In-reply-to Etsuro Fujita message dated "Tue, 29 Aug 2017 17:37:25 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22167.1504041271.1@sss.pgh.pa.us> Date: Tue, 29 Aug 2017 17:14:31 -0400 Message-ID: <22168.1504041271@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Etsuro Fujita writes: > [ epqpath-for-foreignjoin-11.patch ] I started looking at this. I've not yet wrapped my head around what CreateLocalJoinPath() is doing, but I noted that Robert's concerns about ABI breakage in the back branches would not be very difficult to satisfy. What we'd need to do is (1) In the back-branch patch, add the new fields of JoinPathExtraData at the end, rather than in their more natural locations. This should avoid any ABI break for uses of that struct, since there's no reason why an FDW would be creating its own variables of that type rather than just using what the core code passes it. (2) In the back branches, just leave GetExistingLocalJoinPath in place rather than deleting it. Existing FDWs would still be subject to the bug until they were updated, but given how hard it is to trigger, that doesn't seem like a huge problem. A variant of (2) is to install a hack fix in GetExistingLocalJoinPath rather than leaving it unchanged. I'm not very excited about that though; it doesn't seem unlikely that we might introduce new bugs that way, and it would certainly be a distraction from getting the real fix finished. We'd definitely need to do things that way in 9.6. I'm not quite sure whether it's too late to adopt the clean solution in v10. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers