From: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>,
        "Finnerty,
    Jim" <jfinnert@amazon.com>
Subject: Re: Making Vars outer-join aware
In-reply-to: 
 <CAMbWs4_va6UWcaiPSZpeRPFzpA=UKU+4zKkxqdfrcKoKA5nKWA@mail.gmail.com>
References: <830269.1656693747@sss.pgh.pa.us>
 <CAMbWs49KZO2VvMqo+1MQfaX4cun7vhF=5RgVdpA0gjJcj77HFQ@mail.gmail.com>
 <1903934.1657031040@sss.pgh.pa.us> <553080.1657481916@sss.pgh.pa.us>
 <CAMbWs4-0cdVpgY0c2uULBCX2vPjQt3Fx3=XFZh-Mn=UWmxhG-A@mail.gmail.com>
 <1515100.1657633061@sss.pgh.pa.us>
 <CAMbWs4_va6UWcaiPSZpeRPFzpA=UKU+4zKkxqdfrcKoKA5nKWA@mail.gmail.com>
Comments: In-reply-to Richard Guo <guofenglinux@gmail.com>
	message dated "Wed, 13 Jul 2022 15:48:41 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2217145.1657721363.1@sss.pgh.pa.us>
Date: Wed, 13 Jul 2022 10:09:23 -0400
Message-ID: <2217146.1657721363@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2217146.1657721363%40sss.pgh.pa.us>
Precedence: bulk

Richard Guo <guofenglinux@gmail.com> writes:
> But I'm not sure which is better, to evaluate the expression below or
> above the outer join. It seems to me that if the size of base rel is
> large and somehow the size of the joinrel is small, evaluation above the
> outer join would win. And in the opposite case evaluation below the
> outer join would be better.

Reasonable question.  But I think for the purposes of this patch,
it's better to keep the old behavior as much as we can.  People
have probably relied on it while tuning queries.  (I'm not saying
it has to be *exactly* bug-compatible, but simple cases like your
example probably should work the same.)

			regards, tom lane