Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pXrHl-0001Su-FJ
	for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Mar 2023 22:20:25 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pXrHk-0007Px-Ah
	for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Mar 2023 22:20:24 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pXrHk-0007Po-1T
	for pgsql-hackers@lists.postgresql.org; Thu, 02 Mar 2023 22:20:24 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pXrHi-0003Bv-1W
	for pgsql-hackers@postgresql.org; Thu, 02 Mar 2023 22:20:23 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 322MKFLL2217431;
	Thu, 2 Mar 2023 17:20:15 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Isaac Morland <isaac.morland@gmail.com>
cc: Justin Pryzby <pryzby@telsasoft.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Pavel Stehule <pavel.stehule@gmail.com>,
        Magnus Hagander <magnus@hagander.net>, pgsql-hackers@postgresql.org
Subject: Re: Remove source code display from \df+?
In-reply-to: <CAMsGm5f97iYDV9DF8sLjH2Lc+2cjis7OuYVEtGw+c21rGPUy2g@mail.gmail.com>
References: <CAMsGm5dgogOZ5yNc9BsnFM0n4FuykZREmro9f9gvOBWD_D1-2w@mail.gmail.com> <20230122191549.5b35ulimlvz42y7l@alvherre.pgsql> <CAMsGm5f6Cyq3sbjyb2hi1MNjadR=Q-XYr-k_06OmE0vYCF-C8g@mail.gmail.com> <1413123.1674417854@sss.pgh.pa.us> <CAMsGm5eZR_KYmP=vX_OzV9_=9T4XKeu0ysKXYoyB_n-OHgeD8g@mail.gmail.com> <20230122222750.GS13860@telsasoft.com> <CAMsGm5f97iYDV9DF8sLjH2Lc+2cjis7OuYVEtGw+c21rGPUy2g@mail.gmail.com>
Comments: In-reply-to Isaac Morland <isaac.morland@gmail.com>
	message dated "Sun, 22 Jan 2023 20:23:25 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2217429.1677795615.1@sss.pgh.pa.us>
Date: Thu, 02 Mar 2023 17:20:15 -0500
Message-ID: <2217430.1677795615@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/2217430.1677795615%40sss.pgh.pa.us>
Precedence: bulk

Isaac Morland <isaac.morland@gmail.com> writes:
> [ 0001-Remove-source-code-display-from-df-v6.patch ]

Pushed after some editorialization on the test case.

One thing I noticed while testing is that if you apply \df+ to an
aggregate function, it will show "Internal name" of "aggregate_dummy".
While that's an accurate description of what's in prosrc, it seems
not especially useful and perhaps indeed confusing to novices.
So I thought about suppressing it.  However, that would require
a server-version-dependent test and I wasn't quite convinced it'd
be worth the trouble.  Any thoughts on that?

			regards, tom lane