Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ufPMb-006s9F-R2 for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Jul 2025 20:49:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ufPMa-004iwF-Sv for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Jul 2025 20:49:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ufPMa-004iw6-JR for pgsql-hackers@lists.postgresql.org; Fri, 25 Jul 2025 20:49:56 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ufPMX-000pvX-2L for pgsql-hackers@lists.postgresql.org; Fri, 25 Jul 2025 20:49:56 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 56PKnqiA2223528; Fri, 25 Jul 2025 16:49:52 -0400 From: Tom Lane To: Etsuro Fujita cc: Matheus Alcantara , pgsql-hackers@lists.postgresql.org Subject: Re: Fixing memory leaks in postgres_fdw In-reply-to: References: <2976982.1748049023@sss.pgh.pa.us> <216286.1748202797@sss.pgh.pa.us> <519144.1748217540@sss.pgh.pa.us> <918254.1748288174@sss.pgh.pa.us> <1346940.1748381911@sss.pgh.pa.us> <1696019.1748465792@sss.pgh.pa.us> <1876117.1748524672@sss.pgh.pa.us> <2017375.1748530785@sss.pgh.pa.us> <2082618.1748538159@sss.pgh.pa.us> Comments: In-reply-to Etsuro Fujita message dated "Sat, 31 May 2025 20:29:10 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <2223526.1753476592.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Fri, 25 Jul 2025 16:49:52 -0400 Message-ID: <2223527.1753476592@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Etsuro Fujita writes: > On Fri, May 30, 2025 at 2:02 AM Tom Lane wrote: >> Finally, here's a minimalistic version of the original v1-0001 >> patch that I think we could safely apply to fix the DirectModify >> problem in the back branches. I rejiggered it to not depend on >> inventing MemoryContextUnregisterResetCallback, so that there's >> not hazards of minor-version skew between postgres_fdw and the >> main backend. > Seems reasonable. Pushed the larger patchset now. I had to do a little more work to get it to play with 112faf137, but it wasn't hard. regards, tom lane