From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        Noah Misch <noah@leadboat.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: cleaning perl code
In-reply-to: <4FFD55FA-0728-4DC3-AF93-0246FE555C10@enterprisedb.com>
References: <e56f6fb6-38d5-8450-577c-24eb5d63f2e1@2ndQuadrant.com>
 <20200411043014.GA590991@rfd.leadboat.com>
 <0a4406d5-b428-4831-8ed9-c36764360f57@2ndQuadrant.com>
 <97813D8D-F185-4998-8CF8-5678746E7DEE@enterprisedb.com>
 <5b2ae2b0-8b09-d153-275a-24e7b2ac7989@2ndQuadrant.com>
 <4FFD55FA-0728-4DC3-AF93-0246FE555C10@enterprisedb.com>
Comments: In-reply-to Mark Dilger <mark.dilger@enterprisedb.com>
	message dated "Sat, 11 Apr 2020 10:27:58 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <22261.1586626916.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 11 Apr 2020 13:41:56 -0400
Message-ID: <22262.1586626916@sss.pgh.pa.us>
Precedence: bulk

Mark Dilger <mark.dilger@enterprisedb.com> writes:
> I'm less concerned with which perlcritic features you enable than I am w=
ith accidentally submitting perl which looks fine to me but breaks the bui=
ld.  I mostly use perl from within TAP tests, which I run locally before s=
ubmission to the project.  Can your changes be integrated into the TAP_TES=
TS makefile target so that I get local errors about this stuff and can fix=
 it before submitting a regression test to -hackers?

As far as that goes, I think crake is just running

src/tools/perlcheck/pgperlcritic

which you can do for yourself as long as you've got perlcritic
installed.

			regards, tom lane