Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125]) by mail.postgresql.org (Postfix) with ESMTP id 02E581DCB2B2 for ; Mon, 27 Feb 2012 20:21:57 -0400 (AST) Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1S2ApI-0007nk-1G for pgsql-hackers@postgresql.org; Tue, 28 Feb 2012 00:21:56 +0000 Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id q1S0LcEo022329; Mon, 27 Feb 2012 19:21:38 -0500 (EST) To: Andres Freund cc: pgsql-hackers@postgresql.org, Thom Brown , Dimitri Fontaine Subject: Re: Command Triggers, patch v11 In-reply-to: <201202280032.27171.andres@anarazel.de> References: <201202272037.25322.andres@anarazel.de> <201202280032.27171.andres@anarazel.de> Comments: In-reply-to Andres Freund message dated "Tue, 28 Feb 2012 00:32:26 +0100" Date: Mon, 27 Feb 2012 19:21:38 -0500 Message-ID: <22328.1330388498@sss.pgh.pa.us> From: Tom Lane X-Pg-Spam-Score: -1.9 (-) X-Archive-Number: 201202/1361 X-Sequence-Number: 203725 Andres Freund writes: > I refreshed the patch so it works again on current HEAD. Basically some > trivial fixes and dfd26f9c5f371437f243249025863ea9911aacaa. The latter doesn't > seem necessary to me after the changes, so I simply ditched it. Am I missing > something? No, that was only needed because execMain.c was overriding somebody else's tuple receiver. If you're putting the right receiver into the QueryDesc to start with, it shouldn't be necessary. I'm confused by this though: > This basically includes a revert of d8fb1f9adbddd1eef123d66a89a9fc0ecd96f60b I don't find that commit ID anywhere. regards, tom lane