From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Peter Eisentraut <peter@eisentraut.org>,
        Robert Haas <robertmhaas@gmail.com>,
        Nathan Bossart <nathandbossart@gmail.com>,
        pgsql-hackers@postgresql.org
Subject: Re: Why does pgindent's README say to download typedefs.list from the
 buildfarm?
In-reply-to: <Zkaox_udjmTlA6B2@paquier.xyz>
References: <3154983.1713816488@sss.pgh.pa.us>
 <20240422202010.GA420168@nathanxps13> <20240423200455.GA850264@nathanxps13>
 <CA+Tgmoacj1F=h6HQocSo7btsYDE7Sh+9Lz-g=uZpDMFUVMeCjQ@mail.gmail.com>
 <20240515192952.GA1428991@nathanxps13>
 <CA+TgmobNVBN=Ki=N_5s__T3fvvaD3ppawjEs6KrQB5jUXBL2pA@mail.gmail.com>
 <1833482.1715804603@sss.pgh.pa.us> <1919000.1715815925@sss.pgh.pa.us>
 <195c6c45-abce-4331-be6a-e87724e1d060@eisentraut.org>
 <2096381.1715870718@sss.pgh.pa.us> <Zkaox_udjmTlA6B2@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 17 May 2024 09:45:59 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2233227.1715908176.1@sss.pgh.pa.us>
Date: Thu, 16 May 2024 21:09:36 -0400
Message-ID: <2233228.1715908176@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2233228.1715908176%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Thu, May 16, 2024 at 10:45:18AM -0400, Tom Lane wrote:
>> ... I think the enum should be nuked altogether, but
>> it's a bit late to be redesigning that for v17 perhaps.

> You're right, WaitEventExtension is better gone.  The only thing that
> matters is that we want to start computing the IDs assigned to the
> custom wait events for extensions with a number higher than the
> existing WAIT_EXTENSION to avoid interferences in pg_stat_activity, so
> this could be cleaned up as the attached.

WFM, and this is probably a place where we don't want to change the
API in v17 and again in v18, so I agree with pushing now.

Reminder though: beta1 release freeze begins Saturday.
Not many hours left.

			regards, tom lane