From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Amit Kapila <amit.kapila16@gmail.com>, vignesh C <vignesh21@gmail.com>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Unused header file inclusion
In-reply-to: <20190731063749.GQ1577@paquier.xyz>
References: 
 <CALDaNm1B9naPDTm3ox1m_yZvOm3KA5S4kZQSWWAeLHAQ=3gV1Q@mail.gmail.com>
 <20190731055630.GO1577@paquier.xyz>
 <CALDaNm2shkzdA3M=KkrwW9GGYf79ZD9=zfOPHRWs=VXKVEectA@mail.gmail.com>
 <CAA4eK1+d0mPe63sUUZq19n8n8LDyMxHwcXOOXY7EFeJvz9Owcg@mail.gmail.com>
 <20190731063749.GQ1577@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 31 Jul 2019 15:37:49 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <22396.1564580564.1@sss.pgh.pa.us>
Date: Wed, 31 Jul 2019 09:42:44 -0400
Message-ID: <22397.1564580564@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Jul 31, 2019 at 11:55:37AM +0530, Amit Kapila wrote:
>> If we can come up with some such tool, we might be able to integrate
>> it with Thomas's patch tester [1] wherein it can apply the patch,
>> verify if there are unnecessary includes in the patch and report the
>> same.

> Or even get something into src/tools/?  If the produced result is
> clean enough, that could be interesting.

I take it nobody has actually bothered to *look* in src/tools.

src/tools/pginclude/README

Note that our experience with this sort of thing has not been very good.
See particularly 1609797c2.

			regards, tom lane