Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ofuuI-0003kf-3T
	for pgsql-hackers@arkaria.postgresql.org; Wed, 05 Oct 2022 03:17:14 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ofuuG-0005SW-VX
	for pgsql-hackers@arkaria.postgresql.org; Wed, 05 Oct 2022 03:17:12 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ofuuG-0005SN-MZ
	for pgsql-hackers@lists.postgresql.org; Wed, 05 Oct 2022 03:17:12 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ofuuE-0003Kh-DN
	for pgsql-hackers@lists.postgresql.org; Wed, 05 Oct 2022 03:17:11 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2953H9If2241402;
	Tue, 4 Oct 2022 23:17:09 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: bt22nakamorit <bt22nakamorit@oss.nttdata.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: JUMBLE_SIZE macro in two files
In-reply-to: <Yzz2NTLuglb4D8Jo@paquier.xyz>
References: <bb4ebd0412da9b1ac87a5eb2a3646bf1@oss.nttdata.com>
 <1817528.1664889404@sss.pgh.pa.us> <Yzz2NTLuglb4D8Jo@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 05 Oct 2022 12:12:53 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2241400.1664939829.1@sss.pgh.pa.us>
Date: Tue, 04 Oct 2022 23:17:09 -0400
Message-ID: <2241401.1664939829@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2241401.1664939829%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Oct 04, 2022 at 09:16:44AM -0400, Tom Lane wrote:
>> I would go more for taking it out of queryjumble.h.  I see no
>> reason why that constant needs to be world-visible.

> I was just looking at the patch before seeing your reply, and thought
> the exact same thing.  Perhaps you'd prefer apply that yourself?

Nah, feel free.

			regards, tom lane