From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Thomas Munro <thomas.munro@gmail.com>, Andres Freund <andres@anarazel.de>,
        pgsql-hackers@postgresql.org
Subject: Re: pgindent vs variable declaration across multiple lines
In-reply-to: <04fac9c4-d3a9-b563-f197-fa554e87c362@dunslane.net>
References: <20230120013137.7ky7nl4e4zjorrfa@awork3.anarazel.de> <337200.1674179024@sss.pgh.pa.us> <CA+hUKGLcernAWgMaZrkr123LuR8xdvOBz8TXYLXjjzthJkm5gA@mail.gmail.com> <1488202.1674426892@sss.pgh.pa.us> <04fac9c4-d3a9-b563-f197-fa554e87c362@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Tue, 24 Jan 2023 10:20:30 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2242841.1674574415.1@sss.pgh.pa.us>
Date: Tue, 24 Jan 2023 10:33:35 -0500
Message-ID: <2242842.1674574415@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2242842.1674574415%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-01-22 Su 17:34, Tom Lane wrote:
>> I've also attached a diff
>> representing the delta between what current pg_bsd_indent wants to do
>> to HEAD and what this would do.  All the changes it wants to make look
>> good, although I can't say whether there are other places it's failing
>> to change that we'd like it to.

> Changes look good. There are a handful of places where I think the code
> would be slightly more readable if a leading typecast were moved to the
> second line.

Possibly, but that's the sort of decision that pgindent leaves to human
judgment I think.  It'll reflow comment blocks across lines, but I don't
recall having seen it move line breaks within code.

			regards, tom lane