Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyMaa-0007OW-9P for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Mar 2018 19:06:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyMaY-0001Te-Gi for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Mar 2018 19:06:26 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyMaY-0001TV-6T for pgsql-hackers@lists.postgresql.org; Tue, 20 Mar 2018 19:06:26 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyMaV-0006Cr-JB for pgsql-hackers@lists.postgresql.org; Tue, 20 Mar 2018 19:06:24 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w2KJ6ATP022463; Tue, 20 Mar 2018 15:06:10 -0400 From: Tom Lane To: Alvaro Herrera cc: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= , Craig Ringer , PostgreSQL Hackers Subject: Re: configure's checks for --enable-tap-tests are insufficient In-reply-to: <20180320185038.r3hjvfio4elnaqku@alvherre.pgsql> References: <20180320185038.r3hjvfio4elnaqku@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Tue, 20 Mar 2018 15:50:38 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22461.1521572770.1@sss.pgh.pa.us> Date: Tue, 20 Mar 2018 15:06:10 -0400 Message-ID: <22462.1521572770@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alvaro Herrera writes: > Tom Lane wrote: >> Ah, thanks. Not sure we need to make an explicit test for Opcode; we've >> not heard of anyone not having that. > In Debian stable, Opcode is in package libperl5.24. This probably > explains why nobody runs into trouble with it, since libperl is already > checked by configure for other reasons. Not sure about the RH world. [ pokes around ] Opcode is in the base perl package on RHEL6; on Fedora 28, it's in perl-interpreter. Either way, it's in the same package as /usr/bin/perl, so ain't nobody not gonna have it. > As for the others Dagfinn mentioned, most seem to be in perl-base, and a > few in perl-modules-5.24, which is depended upon by libperl5.24, so I > think the proposed set is good enough for now. Sounds good. We can always tweak the list some more if the situation changes, or if we hear from someone using a different distro that slices things up yet differently. But I don't feel a need to expend configure cycles on purely hypothetical configurations. I imagine that most off-the-beaten-track cases would involve hand-built Perl installations, and those will almost certainly have all of "Perl core". So I think as long as we cover what the major Linux distros are doing, that's probably good enough. regards, tom lane