From: Antonin Houska <ah@cybertec.at>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
cc: 'Alvaro Herrera' <alvherre@alvh.no-ip.org>,
    Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
    Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
    Amit Kapila <amit.kapila16@gmail.com>,
    Matthias van de Meent <boekewurm+postgres@gmail.com>,
    Pg Hackers <pgsql-hackers@lists.postgresql.org>,
    Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
In-reply-to: 
 <OS9PR01MB121498680B79ECB53367E269EF55AA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
References: 
 <CADzfLwWFr9h_+cbSQvPpdxgLbVL5wwxFRx21ezNvLYgJM=FVCQ@mail.gmail.com>
 <202604062213.cgo352cdsgsm@alvherre.pgsql>
 <OS9PR01MB121498680B79ECB53367E269EF55AA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
Comments: In-reply-to "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
   message dated "Tue, 07 Apr 2026 12:32:32 -0000."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <225002.1775571560.1@localhost>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 07 Apr 2026 16:19:20 +0200
Message-ID: <225003.1775571560@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/225003.1775571560%40localhost>
Precedence: bulk

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> wrote:

> 02. SnapBuildProcessRunningXacts
> =

> Per my understanding, the db_specic snapshot can be also serialized. Is =
it
> possibility tha normal logical decoding system restores the snapshot and=
 obtain
> the wrong result?

I don't think that the database-specific xl_running_xacts WAL record affec=
ts
what SnapBuildSerialize() writes to disk: the contents of builder->committ=
ed,
etc. is updated by decoding COMMIT and ABORT records.

On the other hand, with that kind of record, there's probably no reason to
call SnapBuildSerialize(). Good catch, thanks.

-- =

Antonin Houska
Web: https://www.cybertec-postgresql.com