public inbox for [email protected]
help / color / mirror / Atom feedFrom: ls7777 <[email protected]>
To: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Subject: Re: Patch for migration of the pg_commit_ts directory
Date: Fri, 29 May 2026 21:08:56 +0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <OS9PR01MB1214994DCC48AF5C0503E5F7AF5082@OS9PR01MB12149.jpnprd01.prod.outlook.com>
References: <[email protected]>
<OSCPR01MB1496660969357E7D16EF4FF12F5E6A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<[email protected]>
<OSCPR01MB14966B4CAB3CC8AE5F8DAD57FF5E7A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAA4eK1+Zayox=x84upet_gc4hrCKSwZSpnO9=Q4vH8rrJbsBOg@mail.gmail.com>
<CACG=ezaFdL4EM8bdrHTRVHt5BmxxWGXcPiDr6Qm00Qj+S_Y+vQ@mail.gmail.com>
<[email protected]>
<OSCPR01MB14966A30D6251B0AE867FEE54F5E0A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<[email protected]>
<OSCPR01MB14966709F525419547BA3F99DF5E0A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<[email protected]>
<OSCPR01MB14966359349E2A205DFB2D6CAF5EEA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<[email protected]>
<OSCPR01MB14966282B927E003022710B76F5EBA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<[email protected]>
<OSCPR01MB14966D4347F7C83697B074223F5E8A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<TY7PR01MB14554CC93E03A125BEE334C1EF586A@TY7PR01MB14554.jpnprd01.prod.outlook.com>
<CAA4eK1KMuhaH=QgzJCwQgawuybosq-JMWWT9qSqyMZNV1MWjtg@mail.gmail.com>
<OS9PR01MB121493384C07100ED5AF5E1E6F568A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
<[email protected]>
<OS9PR01MB12149D792103A1C87FE2903DCF546A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
<[email protected]>
<OS9PR01MB12149465FC118EFA745E380DEF547A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
<[email protected]>
<CAD21AoDG8zQpHHfw7OvaEy7W0ZSyP=_dS-hrcquJ3C_ctMDmMQ@mail.gmail.com>
<[email protected]>
<OS9PR01MB12149BC0A686B802D4C8D4FE3F54FA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
<[email protected]>
<[email protected]>
<[email protected]>
<OS9PR01MB1214994DCC48AF5C0503E5F7AF5082@OS9PR01MB12149.jpnprd01.prod.outlook.com>
<div>Hi,</div><div> </div><div><div>During copying, the copy_subdir_files function cleans up the target directory with the remove_new_subdir(new_subdir, true) function.</div><div> </div></div><div><br /></div><div><br /></div><div>----------------</div>
<div>Кому: 'ls7777' ([email protected]);<br /></div>
<div>Копия: [email protected], [email protected], [email protected], Masahiko Sawada ([email protected]);<br /></div>
<div>Тема: Patch for migration of the pg_commit_ts directory;<br /></div>
<div>27.05.2026, 10:25, "Hayato Kuroda (Fujitsu)" <[email protected]>:<br /></div>
<blockquote><p>Dear Sergey,<br /><br />While considering the feature once again, I came up with another issue.<br /><br />When pg_upgrade migrates objects to a new instance, it normally checks whether<br />the new instance does not have existing objects. E.g., check_new_cluster_is_empty()<br />checks if no tables exist, and check_new_cluster_replication_slots() ensures<br />there are no logical slots.<br /><br />Based on that, how should we handle the commit timestamp? Since the patch simply<br />copies the pg_commit_ts subdir, existing entries in the new cluster will be overwritten.<br />So we may have to check if the commit_ts entries are empty when the pg_upgrade<br />command runs, but not sure how to do that.<br /><br />Best regards,<br />Hayato Kuroda<br />FUJITSU LIMITED<br /> <br /></p></blockquote>
view thread (15+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Patch for migration of the pg_commit_ts directory
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox