Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: Define DatumGetInt8 function.
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CALdSSPhFyb9qLSHee73XtZm1CBWJNo9+JzFNf-zUEWCRW5yEiQ@mail.gmail.com>
Date: Mon, 29 Dec 2025 19:08:25 +0800
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: 7bit
Message-Id: <225E9E96-D160-49CD-97CA-A9AE20B60A8B@gmail.com>
References: 
 <CALdSSPhFyb9qLSHee73XtZm1CBWJNo9+JzFNf-zUEWCRW5yEiQ@mail.gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/225E9E96-D160-49CD-97CA-A9AE20B60A8B%40gmail.com>
Precedence: bulk


> On Dec 29, 2025, at 19:02, Kirill Reshke <reshkekirill@gmail.com> wrote:
> 
> Hi hackers!
> 
> I am currently involved in the Cloudberry kernel rebase process[0]. We
> are rebasing [0] which is based on pg-14 on pg-16 kernel. During this
> process I noticed rebase conflicts introduced  by c8b2ef0. This commit
> defines a number of include functions for datum conversion.
> 
> During this rebase resolution, I noticed that there is an Int8GetDatum
> function, but there is no DatumGetInt8, which I want to use. All other
> inline functions seem to be provided in pairs by postgres.h. So it
> looks convenient to define DatumGetInt8 in postgres.h?
> 
> FPA doing just that.
> 
> 
> [0] https://github.com/apache/cloudberry
> 
> -- 
> Best regards,
> Kirill Reshke
> <v1-0001-Define-DatumGetInt8-function.patch>

LGTM.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/