Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rNOVx-00BYlG-EU
	for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Jan 2024 02:40:21 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rNOVv-00H4y1-GT
	for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Jan 2024 02:40:19 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rNOVv-00H4xt-7W
	for pgsql-hackers@lists.postgresql.org; Wed, 10 Jan 2024 02:40:19 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rNOVs-000kpT-UT
	for pgsql-hackers@lists.postgresql.org; Wed, 10 Jan 2024 02:40:18 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 40A2eCop2266941;
	Tue, 9 Jan 2024 21:40:12 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Robert Haas <robertmhaas@gmail.com>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 kuroda.hayato@fujitsu.com,
        shlok.kyal.oss@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_ctl start may return 0 even if the postmaster has been already
 started on Windows
In-reply-to: <ZZ32c6vZzrLIrM9q@paquier.xyz>
References: 
 <TYAPR01MB5866F5F7764669A07C7F5E2FF5D8A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
 <20231024.150027.1529972066789460167.horikyota.ntt@gmail.com>
 <TYAPR01MB586640F8FFA4F87902BDF677F5DFA@TYAPR01MB5866.jpnprd01.prod.outlook.com>
 <20231024.172536.511643991820398116.horikyota.ntt@gmail.com>
 <CA+TgmoaYOON0cQPR0Aj_ZD2005+sschuMisSQV7xPqzxrx7vaQ@mail.gmail.com>
 <ZZyV99g76Q3-YwEn@paquier.xyz> <ZZ32c6vZzrLIrM9q@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 10 Jan 2024 10:44:19 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2266939.1704854412.1@sss.pgh.pa.us>
Date: Tue, 09 Jan 2024 21:40:12 -0500
Message-ID: <2266940.1704854412@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2266940.1704854412%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> I have now applied 0001 for pg_ctl.

> While reviewing that, I have also noticed spawn_process() in
> pg_regress.c that includes direct command invocations with cmd.exe /c.
> Could it make sense to append an extra /d for this case as well?

No Windows expert here, but it does seem like the same argument
applies.

			regards, tom lane