Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow8Oj-0000iz-39 for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Nov 2022 20:55:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ow8Oh-0003Yj-VW for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Nov 2022 20:55:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow8Oh-0003Ya-Lb for pgsql-hackers@lists.postgresql.org; Fri, 18 Nov 2022 20:55:39 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow8Oe-00069E-JE for pgsql-hackers@lists.postgresql.org; Fri, 18 Nov 2022 20:55:38 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2AIKtYO42267407; Fri, 18 Nov 2022 15:55:34 -0500 From: Tom Lane To: pgsql-hackers@lists.postgresql.org cc: Tomas Vondra Subject: test/modules/test_oat_hooks vs. debug_discard_caches=1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2267405.1668804934.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 18 Nov 2022 15:55:34 -0500 Message-ID: <2267406.1668804934@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk We realized today [1] that it's been some time since the buildfarm had any debug_discard_caches (nee CLOBBER_CACHE_ALWAYS) coverage. Sure enough, as soon as Tomas turned that back on, kaboom [2]. The test_oat_hooks test is failing --- it's not crashing, but it's emitting more NOTICE lines than the expected output includes, evidently as a result of the hooks getting invoked extra times during cache reloads. I can reproduce that here. Maybe it was a poor design that these hooks were placed someplace that's sensitive to that. I dunno. The only short-term solution I can think of is to force debug_discard_caches to 0 within that test script, which is annoying but feasible (since that module only exists in v15+). Thoughts, other proposals? regards, tom lane [1] https://www.postgresql.org/message-id/6b52e783-1b32-e723-4311-0e433a5a= 5a75%40enterprisedb.com [2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Davocet&dt=3D= 2022-11-18%2016%3A01%3A43