From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
cc: Magnus Hagander <magnus@hagander.net>, Bruce Momjian <bruce@momjian.us>,
        Christoph Berg <myon@debian.org>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Fujii Masao <masao.fujii@oss.nttdata.com>,
        PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
In-reply-to: <20210426172354.GV20766@tamriel.snowman.net>
References: <20210424152220.GL7629@momjian.us>
 <CABUevEx4YQi42MwaMq3Bo09=mBqfjUqtkp5NUZpnQ0HdX+5+Hw@mail.gmail.com>
 <20210424170908.GM7629@momjian.us> <1709439.1619286231@sss.pgh.pa.us>
 <e832ac41-00dd-3a05-7f52-4b2ae4613508@enterprisedb.com>
 <YIbdhrfemBnwAvl5@msg.df7cb.de> <20210426162104.GQ7629@momjian.us>
 <20210426163135.GU20766@tamriel.snowman.net>
 <2267128.1619456173@sss.pgh.pa.us>
 <CABUevExH+nLxfYqbUYV3zB7QqaCrzxRAbnTrs0Dbt4f0W1Xn=A@mail.gmail.com>
 <20210426172354.GV20766@tamriel.snowman.net>
Comments: In-reply-to Stephen Frost <sfrost@snowman.net>
	message dated "Mon, 26 Apr 2021 13:23:54 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2268610.1619458140.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Mon, 26 Apr 2021 13:29:00 -0400
Message-ID: <2268611.1619458140@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2268611.1619458140%40sss.pgh.pa.us>
Precedence: bulk

Stephen Frost <sfrost@snowman.net> writes:
> * Magnus Hagander (magnus@hagander.net) wrote:
>> Thatäs why I suggested the three value one. Default to a mode where
>> it's automatic, which is what the majority is going to want, but have
>> a way to explicitly turn it on.

> This is certainly fine with me too, though it seems a bit surprising to
> me that we couldn't just figure out what the user actually wants based
> on what's installed/running for any given combination.

I'd be on board with having pg_stat_statement's pg_init function do
something to adjust the setting, if we can figure out how to do that
in a way that's not confusing in itself.  I'm not sure though that
the GUC engine offers a good way.

			regards, tom lane