public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: Jonathan S. Katz <[email protected]>
Cc: David Rowley <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: [email protected]
Subject: Re: On disable_cost
Date: Fri, 23 Aug 2024 13:42:53 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmobuPzMHUp11O9PP2tMBE_pse8p5J5_829eHEpZd0uibAg@mail.gmail.com>
References: <CAO0i4_SSPV9TVxbbTRVLOnCyewopcc147fBZy=f2ABk15eHS+g@mail.gmail.com>
<[email protected]>
<CA+Tgmoa-nn+jypLTiG1BzOHLL1O-heSzyCrPPbw=Ah7McEex4A@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAApHDvrTWY+5TrDs4PDeRAMXdP+mE0QGFR5OiBjLB-oOLj9v8A@mail.gmail.com>
<CA+TgmoZ_+MS+o6NeGK2xyBv-xM+w1AfFVuHE4f_aq6ekHv7YSQ@mail.gmail.com>
<CAApHDvq00TXpvN0hGDczQ9hMcNGCKY7=GVoH_FpXg=0MwjfO5g@mail.gmail.com>
<CA+TgmoZRwy8202vxbUPBeZd_Tx5NYVtmpvBnJnOzZS3b81cpkg@mail.gmail.com>
<CAApHDvo8EFm5A5f2S5hKEqSETTymnbSbFe=P-EJ=-8sAGKfWnA@mail.gmail.com>
<CA+TgmoYfiQYpT52FH+HWXmg6k8kGjrL6oq1g8Ca+kLAFwRyy=Q@mail.gmail.com>
<CAApHDvriW5ra-ACRoesr5U4Xq5uoQ7RMPupLpLZ9aD+Cjp-KVg@mail.gmail.com>
<CA+TgmoYTWfSw8hOfvk1MfoHOBJYeRQaC0KrrX6_GhbJxfXwDRQ@mail.gmail.com>
<[email protected]>
<CA+TgmoacM-Lxqa5Y9kvTmUUjeuWAoFxYgn3Gj+NP6soRdcm-uw@mail.gmail.com>
<[email protected]>
<CA+TgmoaAWQJ! [email protected]>
<[email protected]>
<CA+TgmobuPzMHUp11O9PP2tMBE_pse8p5J5_829eHEpZd0uibAg@mail.gmail.com>
Robert Haas <[email protected]> writes:
> On Fri, Aug 23, 2024 at 1:26 PM Tom Lane <[email protected]> wrote:
>> It looks like amcostestimate could change the path's disabled_nodes
>> count, since that's set up before invoking amcostestimate. I guess
>> it could be set to INT_MAX to have a comparable solution to before.
> It's probably better to add a more modest value, to avoid overflow.
> You could add a million or so and be far away from overflow while
> presumably still being more disabled than any other path.
But that'd only matter if the path survived its first add_path
tournament, which it shouldn't. If it does then you're at risk
of the same run-time failure reported here.
(Having said that, you're likely right that "a million or so"
would be a safer choice, since it doesn't require the assumption
that the path fails instantly.)
regards, tom lane
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: On disable_cost
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox