Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gcHGH-0005sD-MS
	for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Dec 2018 22:02:45 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gcHGG-0001v3-4v
	for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Dec 2018 22:02:44 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gcHGF-0001uw-QA
	for pgsql-hackers@lists.postgresql.org; Wed, 26 Dec 2018 22:02:43 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gcHGC-0007kG-MA
	for pgsql-hackers@postgresql.org; Wed, 26 Dec 2018 22:02:42 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wBQM2baT022709;
	Wed, 26 Dec 2018 17:02:37 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: Noah Misch <noah@leadboat.com>, pgsql-hackers@postgresql.org
Subject: Re: Move regression.diffs of pg_upgrade test suite
In-reply-to: <ede9f7a3-2082-ce59-abb0-fe867dc03bbb@2ndQuadrant.com>
References: <20181224034411.GA3224776@rfd.leadboat.com>
 <ede9f7a3-2082-ce59-abb0-fe867dc03bbb@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Mon, 24 Dec 2018 15:11:33 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <22707.1545861757.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 26 Dec 2018 17:02:37 -0500
Message-ID: <22708.1545861757@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 12/23/18 10:44 PM, Noah Misch wrote:
>> A disadvantage of any change here is that it degrades buildfarm reports=
, which
>> recover slowly as owners upgrade to a fixed buildfarm release.  This wi=
ll be
>> similar to the introduction of --outputdir=3Doutput_iso.  On non-upgrad=
ed
>> animals, pg_upgradeCheck failures will omit regression.diffs.
>> =

>> I think the right fix, attached, is to use "pg_regress --outputdir" to
>> redirect these files to src/bin/pg_upgrade/tmp_check/regress.

> Seems reasonable.

Do we need to change anything in the buildfarm client to improve its
response to this?  If so, seems like it might be advisable to make a
buildfarm release with the upgrade before committing the change.
Sure, not all owners will update right away, but if they don't even
have the option then we're not in a good place.

			regards, tom lane