From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
cc: "Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [Bug fix]If recovery.conf has target_session_attrs=read-write,
 the standby fails to start.
In-reply-to: 
 <CAB7nPqTmym5t-X6hvMF_P-KRc=ndXtbQCTiU=NhS_jvL7x1kCA@mail.gmail.com>
References: <1803D792815FC24D871C00D17AE95905B1A34A@g01jpexmbkw24>
 <CAB7nPqQafwnsKAZ9sv9D8wE_3HU6gge6L0QuPXp9yK=4-2oC1A@mail.gmail.com>
 <1803D792815FC24D871C00D17AE95905B1A4CA@g01jpexmbkw24>
 <24403.1495225931@sss.pgh.pa.us>
 <CAB7nPqTmym5t-X6hvMF_P-KRc=ndXtbQCTiU=NhS_jvL7x1kCA@mail.gmail.com>
Comments: In-reply-to Michael Paquier <michael.paquier@gmail.com>
	message dated "Sat, 20 May 2017 09:27:54 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <22754.1495241340.1@sss.pgh.pa.us>
Date: Fri, 19 May 2017 20:49:00 -0400
Message-ID: <22755.1495241340@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Michael Paquier <michael.paquier@gmail.com> writes:
> Do you think that it would be better to list the letter list for each
> keyword in repl_scanner.l or have something more generic? As not that
> many commands are added in the replication protocol, I would think
> that this is more than enough for each command, say:
> [Ss][Ll][Oo][Tt]                { return K_SLOT; }
> etc.

Yeah, that's probably good enough.  It might be worth the trouble to
make out-of-line definitions, as in cubescan.l's handling of NaN and
Infinity for instance, but that's just cosmetic.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers