Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chhAy-0002Vp-4n for pgsql-hackers@arkaria.postgresql.org; Sat, 25 Feb 2017 18:34:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1chhAx-0001WJ-Kh for pgsql-hackers@arkaria.postgresql.org; Sat, 25 Feb 2017 18:34:35 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1chhAw-0001WD-RI for pgsql-hackers@postgresql.org; Sat, 25 Feb 2017 18:34:34 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1chhAu-0007U9-JA for pgsql-hackers@postgresql.org; Sat, 25 Feb 2017 18:34:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v1PIYVDL022792; Sat, 25 Feb 2017 13:34:31 -0500 From: Tom Lane To: Andrew Dunstan cc: PostgreSQL-development Subject: Re: btree_gin and btree_gist for enums In-reply-to: <4e730f28-742b-45e9-d507-4d292fbd7834@2ndQuadrant.com> References: <56EA8A71.8060107@dunslane.net> <56EACB8C.1040406@dunslane.net> <03f7d748-0f89-e8e1-094d-f04e1026b93d@dunslane.net> <27220.1478360811@sss.pgh.pa.us> <31412.1478366009@sss.pgh.pa.us> <60fb708c-8b3c-1337-934e-c1bfe2afc539@dunslane.net> <8258.1487886101@sss.pgh.pa.us> <4376a7bf-ab8c-e640-9021-94b148f9d733@2ndQuadrant.com> <6704.1487952174@sss.pgh.pa.us> <930cb563-6dc6-c4af-3be9-31f06c60361e@2ndQuadrant.com> <8a8c60b4-39c0-69a4-824c-e364f5fd97ea@2ndQuadrant.com> <12734.1488042261@sss.pgh.pa.us> <4e730f28-742b-45e9-d507-4d292fbd7834@2ndQuadrant.com> Comments: In-reply-to Andrew Dunstan message dated "Sat, 25 Feb 2017 12:27:36 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22790.1488047671.1@sss.pgh.pa.us> Date: Sat, 25 Feb 2017 13:34:31 -0500 Message-ID: <22791.1488047671@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Andrew Dunstan writes: > On 02/25/2017 12:04 PM, Tom Lane wrote: >> I think it'd be better to leave DirectFunctionCallN alone and just invent >> a small number of CallerFInfoFunctionCallN support functions (maybe N=1 >> and N=2 would be enough, at least for now). > See attached. Yeah, I like this better, except that instead of + * The callee should not look at anything except the fn_mcxt and fn_extra. + * Anything else is likely to be bogus. maybe + * It's recommended that the callee only use the fn_extra and fn_mcxt + * fields, as other fields will typically describe the calling function + * not the callee. Conversely, the calling function should not have + * used fn_extra, unless its use is known compatible with the callee's. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers