Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wdTbq-0047mj-36 for pgsql-hackers@arkaria.postgresql.org; Sat, 27 Jun 2026 14:02:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wdTbn-00FNt3-1K for pgsql-hackers@arkaria.postgresql.org; Sat, 27 Jun 2026 14:02:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wdTbm-00FNsv-37 for pgsql-hackers@lists.postgresql.org; Sat, 27 Jun 2026 14:02:11 +0000 Received: from mail-dy1-x132e.google.com ([2607:f8b0:4864:20::132e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wdTbk-00000000TzN-3U0M for pgsql-hackers@postgresql.org; Sat, 27 Jun 2026 14:02:09 +0000 Received: by mail-dy1-x132e.google.com with SMTP id 5a478bee46e88-30c09f29b64so1311845eec.0 for ; Sat, 27 Jun 2026 07:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20251104.gappssmtp.com; s=20251104; t=1782568928; x=1783173728; darn=postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=PFgrhT7DLEd9ngHH5Q1lMymNeBuhxK34sIsYssLDrpw=; b=EEh2U3WKTY99dU0zxURjRvXOzFC28M1/52NKYBOljioWovx0xPID8ga+xtGmTCO4OY JEor2qFhqqHvB08xx23TwvLmu7KV1+OzJzyMEO/IUqhkbKh9DE4vLF4WAwe/Q6MjZyJN PChfA6sOIzj4nFh7Fbtni9zuUEjuVZS1ROPr8I1LEJGC1C/nNOW4Mk9aMccADPsuCi94 k3UyhN8wd/WqPjHLOjyLFXAV0Z0PgWAfXahaoBlSnmMlzCmCi/zTIV5WvqjIpliZOQee gu0c8ycs71p+tjBX90+feD1c1Lac0LMF2F2UaHL9bGHSedLD2NCo7VWgmUCrr2k7Tlhw 0XEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782568928; x=1783173728; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PFgrhT7DLEd9ngHH5Q1lMymNeBuhxK34sIsYssLDrpw=; b=F0Qn2ou9JT1+U/IR9SAX17PBLinNBF4LPRy8Ps19ckVDkatqCK6vBqEouAxM4n0Gbk sQdtushlqhfjKNwP1BmumBuTrK6wdV1Z4IgFh6uQ2OPbZ+Qz1Ka0YiwVdi8yGcFW5Zn0 Uo+c6klsRWNOhMKq1hLbRO/lF3urw6nN1oKdVsDQX6Jf2ALGfNSs1luKwMPIls/5jv4o ix5Y7a+/cK3jORltn/mYkBqlhrgljgj3LxxdYZvUBfKu0TBQ3P17QAqgt7Eh5a6cNVsY AZDAP85zYbLg+xTeIMMWIWGxfdMw/xvzzfNft90CTJHFydfeNmCjEuadRRelEwYbEAS0 LNmg== X-Gm-Message-State: AOJu0YxzTDwyuyB+9ALmftVjzzw79EK+kxrxFVcHrfw/xRWm9x9OqubN qLBuZHhLtFtfBTHLEVItyIFODG30TviUz4jbkPVGCspdB9GBLkJRjTX/q+WUZrs3+A== X-Gm-Gg: AfdE7ck4rjrSlJ8WUporEkF8VnZrvpZR0TWfz9B6815tebkFJNYQIpU3TtGgolW6LIW aakEJQhUTjkss6t4ncLFJLEPSfpj+YOODft6ZLGtVI/Lo5Ag4Z0QMzx0ysAvK6M+sVhDYbj9KYT tuDai7zCkCY9DW82hJ3W9EUUnCykONQDXHv+Ekq9yR+gT7KqU9xcKYMEKbYD3ze802cPuXiXjqB cQFYErbj/iWN/spO684Ah3W10n4yJqkTcr69EZ/gvWnc1j/yney47d9tvueLuQZsFkGaPfJOQZs UsH99fXAQxyAQwxIMCh/HXD8o9N0zbANbb+t2x5QmpX+ZM1LS9UrjqllIuZHaN3qCI9I+c18gsq jBfUK8NZdk1Tb1WyLUVnLGAXGClC70qF1FqUbQjRLgz4BsH8oz3sO0g1205wROoCp5RZ8R7LZC/ WNuNapAj5WnuZHrm/7mJtJupZmbNKz/GfCfusSzc3l8n6ibQ== X-Received: by 2002:a05:7300:ec18:b0:30c:ab96:7306 with SMTP id 5a478bee46e88-30cab96771emr4330540eec.22.1782568927569; Sat, 27 Jun 2026 07:02:07 -0700 (PDT) Received: from jeff-ws-bridge.lan (c-24-7-19-3.hsd1.ca.comcast.net. [24.7.19.3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c944999adsm22435615eec.24.2026.06.27.07.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jun 2026 07:02:06 -0700 (PDT) Message-ID: <227d0c0c6c7a23c297033df01ad010cbeea5fb09.camel@j-davis.com> Subject: Re: Small patch to improve safety of utf8_to_unicode(). From: Jeff Davis To: Chao Li Cc: pgsql-hackers@postgresql.org Date: Sat, 27 Jun 2026 07:02:05 -0700 In-Reply-To: <16CAD4DB-9D4A-481A-BB4E-78775C4F4B2C@gmail.com> References: <541F240E-94AD-4D65-9794-7D6C316BC3FF@gmail.com> <313BCA0E-2E74-4EB6-9AA8-10DB7F439151@gmail.com> <592441c1d871a4ed0ac1708e132f447caa35869c.camel@j-davis.com> <3058CAA1-40E0-4098-893B-615F77CD35E1@gmail.com> <0cedb517aee8b79b8e31a4e42885ed88c2a67c5f.camel@j-davis.com> <16CAD4DB-9D4A-481A-BB4E-78775C4F4B2C@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1.1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, 2026-06-26 at 12:38 +0800, Chao Li wrote: > Sounds like 0001 will be back patched. In that case, the commit > message "defend against invalid UTF8=E2=80=9D seems too broad. Does it ma= ke > sense to add some brief description about the defend behavior to the > function header comment and the commit message? Right. Would "defend against truncated byte sequences" or "defend against truncated UTF8" be better wording? Regards, Jeff Davis