From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Geier <geidav.pg@gmail.com>
cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add explicit casts in four places to simplehash.h
In-reply-to: <0f0d2561-1190-1f45-0c5f-ed42f2c80aaf@gmail.com>
References: <aa5d88a3-71f4-3455-11cf-82de0372c941@gmail.com>
 <2063437.1667487018@sss.pgh.pa.us>
 <0f0d2561-1190-1f45-0c5f-ed42f2c80aaf@gmail.com>
Comments: In-reply-to David Geier <geidav.pg@gmail.com>
	message dated "Fri, 04 Nov 2022 09:23:54 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2280952.1667568342.1@sss.pgh.pa.us>
Date: Fri, 04 Nov 2022 09:25:42 -0400
Message-ID: <2280953.1667568342@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2280953.1667568342%40sss.pgh.pa.us>
Precedence: bulk

David Geier <geidav.pg@gmail.com> writes:
> On 11/3/22 15:50, Tom Lane wrote:
>> The bigger picture here is that we do actually endeavor to keep
>> (most of) our headers C++ clean, but our tool cpluspluscheck misses
>> these problems because it doesn't try to use these macros.
>> I wonder whether there is a way to do better.

> What about having a custom header alongside cpluspluscheck which 
> references all macros we care about?

Can't see that that would help, because of the hand maintenance
required to make it useful.

			regards, tom lane