Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hO2d8-0001x6-53 for pgsql-hackers@arkaria.postgresql.org; Tue, 07 May 2019 16:07:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hO2d6-0004Zx-UN for pgsql-hackers@arkaria.postgresql.org; Tue, 07 May 2019 16:07:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hO2d6-0004Zp-Ln for pgsql-hackers@lists.postgresql.org; Tue, 07 May 2019 16:07:44 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hO2d4-0002oX-KQ for pgsql-hackers@lists.postgresql.org; Tue, 07 May 2019 16:07:44 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x47G7bO3002284; Tue, 7 May 2019 12:07:37 -0400 From: Tom Lane To: Andres Freund cc: pgsql-hackers@lists.postgresql.org, Michael Paquier Subject: Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6 In-reply-to: <20190507155931.pv54deg543goz73h@alap3.anarazel.de> References: <20190502210253.lt4p46dvllxarajg@alap3.anarazel.de> <17927.1556839099@sss.pgh.pa.us> <20190504130637.GA5975@paquier.xyz> <4622.1556982247@sss.pgh.pa.us> <20190505184816.p7nweo6bnh76k5ev@alap3.anarazel.de> <1105.1557115018@sss.pgh.pa.us> <037F6AFC-73CC-41B3-A0F0-75AF5AE06372@anarazel.de> <1236.1557115204@sss.pgh.pa.us> <20190506070105.2jo5f4vah5mo32m2@alap3.anarazel.de> <28030.1557240619@sss.pgh.pa.us> <20190507155931.pv54deg543goz73h@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Tue, 07 May 2019 08:59:31 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2282.1557245257.1@sss.pgh.pa.us> Date: Tue, 07 May 2019 12:07:37 -0400 Message-ID: <2283.1557245257@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andres Freund writes: > Yea, that might be right. I'm planning to leave the tests in until a > bunch of the open REINDEX issues are resolved. Not super likely that > it'd break something, but probably worth anyway? The number of deadlock failures is kind of annoying, so I'd rather remove the tests from HEAD sooner than later. What issues around that do you think remain that these tests would be helpful for? regards, tom lane