Subject: Re: Fix pg_upgrade to preserve datdba
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>,
 Robins Tharakan <tharakan@gmail.com>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <a9f9376f1c3343a6bb319dce294e20ac@EX13D05UWC001.ant.amazon.com>
 <CABUevEwyLb9VE0D+bAQtUnaA7bffXYzBpopYuh7kGTQxY9T5_g@mail.gmail.com>
 <CAEP4nAw2WA1wyb9LG7BOEuN3Xr-xWiZZ0w_hKtpyvdUPKmcAJA@mail.gmail.com>
 <1742698.1615221182@sss.pgh.pa.us>
 <CABUevEzvU07CqwGdaOmxNfDtrkY-xEcLjiN3GAmurowyCnbG7w@mail.gmail.com>
 <1743618.1615222719@sss.pgh.pa.us>
 <4fbf92f2-ec91-f4fa-a259-f0968e34f3d7@wi3ck.info>
 <0b5d506d-70d2-1506-bbdf-89e6453c0289@wi3ck.info>
 <384713.1616345832@sss.pgh.pa.us>
From: Jan Wieck <jan@wi3ck.info>
Message-ID: <2284b71d-af55-2625-f8c2-cedf1f1a70ca@wi3ck.info>
Date: Sun, 21 Mar 2021 13:15:54 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <384713.1616345832@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/2284b71d-af55-2625-f8c2-cedf1f1a70ca%40wi3ck.info>
Precedence: bulk

On 3/21/21 12:57 PM, Tom Lane wrote:
> Jan Wieck <jan@wi3ck.info> writes:
>> On 3/20/21 12:39 AM, Jan Wieck wrote:
>>> On the way pg_upgrade also mangles the pg_database.datdba
>>> (all databases are owned by postgres after an upgrade; will submit a
>>> separate patch for that as I consider that a bug by itself).
> 
>> Patch attached.
> 
> Hmm, doesn't this lose all *other* database-level properties?
> 
> I think maybe what we have here is a bug in pg_restore, its
> --create switch ought to be trying to update the database's
> ownership.

Possibly. I didn't look into that route.


Regards, Jan

-- 
Jan Wieck
Principle Database Engineer
Amazon Web Services