From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests
In-reply-to: <20190908233559.GA2467@paquier.xyz>
References: <6628.1567958876@sss.pgh.pa.us>
 <5e1113b9-e1a6-d68b-c05c-06e607a4cd5f@2ndQuadrant.com>
 <17551.1567979940@sss.pgh.pa.us>
 <688d32cf-19be-c8f0-f08b-fde25d15132e@2ndQuadrant.com>
 <18363.1567981113@sss.pgh.pa.us> <20190908233559.GA2467@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 09 Sep 2019 08:35:59 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <22858.1567986256.1@sss.pgh.pa.us>
Date: Sun, 08 Sep 2019 19:44:16 -0400
Message-ID: <22859.1567986256@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> I think that it is a good idea to add in subdircheck an extra path to
> check after TAP tests and run optionally these on top of the normal
> regression tests.  I have a couple of comments.

> Shouldn't we check after TAP_TESTS in the Makefile?

Yeah, perhaps, but I wasn't sure about how to do that easily.
Feel free to add it ...

> There is an argument to also check after isolation tests and run
> them.

Hm, yeah, if there are any such tests in those directories.

> The glob() part is a good idea in itself I think.  Why not
> back-patching it?  I could double-check it as well.

The whole thing should be back-patched into branches that have
any affected tests.  (But, please, not till after beta4 is
tagged.)

			regards, tom lane