Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1saLe6-0089TQ-1A for pgsql-hackers@arkaria.postgresql.org; Sat, 03 Aug 2024 20:46:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1saLe3-006vgj-7M for pgsql-hackers@arkaria.postgresql.org; Sat, 03 Aug 2024 20:46:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1saLe2-006vgb-U3 for pgsql-hackers@lists.postgresql.org; Sat, 03 Aug 2024 20:46:30 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1saLe0-002uzX-Dx for pgsql-hackers@postgresql.org; Sat, 03 Aug 2024 20:46:29 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 473KkNbe228701; Sat, 3 Aug 2024 16:46:23 -0400 From: Tom Lane To: Peter Eisentraut cc: pgsql-hackers , Heikki Linnakangas , Andres Freund Subject: Re: consider -Wmissing-variable-declarations In-reply-to: References: <69d9824f-00ea-49b6-b68d-96f0806ec454@iki.fi> <5cf9f601-a9e7-48ed-a007-714209e9779f@eisentraut.org> <20240618150238.hm6tr4prhe7porhq@awork3.anarazel.de> <6070f0ee-176f-4e78-9324-3bbb70a191f9@eisentraut.org> Comments: In-reply-to Peter Eisentraut message dated "Sat, 03 Aug 2024 14:15:14 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <228699.1722717983.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 03 Aug 2024 16:46:23 -0400 Message-ID: <228700.1722717983@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > This has all been committed now. Various buildfarm animals are complaining about g++ -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-stateme= nt -Werror=3Dvla -Werror=3Dunguarded-availability-new -Wendif-labels -Wmis= sing-format-attribute -Wcast-function-type -Wformat-security -Wmissing-var= iable-declarations -fno-strict-aliasing -fwrapv -fexcess-precision=3Dstand= ard -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -= Wno-cast-function-type-strict -g -O2 -Wno-deprecated-declarations -fPIC -= fvisibility=3Dhidden -shared -o llvmjit.so llvmjit.o llvmjit_error.o llvm= jit_inline.o llvmjit_wrap.o llvmjit_deform.o llvmjit_expr.o -L../../../../= src/port -L../../../../src/common -L/usr/lib64 -Wl,--as-needed -Wl,-rpa= th,'/home/centos/17-lancehead/buildroot/HEAD/inst/lib',--enable-new-dtags = -fvisibility=3Dhidden -lLLVM-17 = g++: error: unrecognized command line option \342\200\230-Wmissing-variabl= e-declarations\342\200\231; did you mean \342\200\230-Wmissing-declaration= s\342\200\231? make[2]: *** [../../../../src/Makefile.shlib:261: llvmjit.so] Error 1 It looks like we are passing CFLAGS not CXXFLAGS to this particular g++ invocation. regards, tom lane