From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Noah Misch <noah@leadboat.com>, Thomas Munro <thomas.munro@gmail.com>,
        Vik Fearing <vik@postgresfriends.org>,
 cary huang <hcary328@gmail.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Add support for AT LOCAL
In-reply-to: <ZSzmdDenWESX5jmW@paquier.xyz>
References: 
 <CA+hUKGL04vme+yztreEFhGucv2d9ema+8_a+i43EUFdpYCPXfw@mail.gmail.com>
 <ZSyYqySa74x_RAH_@paquier.xyz>
 <CA+hUKGLYaVJ7df+Uu=ctUunRcqUsGY55feVQa-1pzz1=PT=z3w@mail.gmail.com>
 <2188264.1697425365@sss.pgh.pa.us>
 <CA+hUKGJSEOVonGsYCiuhZXsBFCxXtjNyHGYvn-w9jykGo2PgqQ@mail.gmail.com>
 <2191749.1697427017@sss.pgh.pa.us> <20231016045804.c0@rfd.leadboat.com>
 <20231016055051.3a@rfd.leadboat.com> <2208907.1697435663@sss.pgh.pa.us>
 <20231016060510.72@rfd.leadboat.com> <ZSzmdDenWESX5jmW@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 16 Oct 2023 16:29:56 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2287834.1697464481.1@sss.pgh.pa.us>
Date: Mon, 16 Oct 2023 09:54:41 -0400
Message-ID: <2287835.1697464481@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2287835.1697464481%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Perhaps that's a stupid question..  But a server running under this
> environment fails the two following queries even for older branches,
> right?
> select timezone('UTC', '23:59:59.99-07'::timetz);
> select timezone('UTC', '23:59:00-07'::timetz);

One would expect, since the AT LOCAL syntax is just sugar for that.

I'm mighty tempted though to (a) add coverage for timetz_izone
to HEAD, and (b) backpatch the new tests, sans the AT LOCAL case,
to the back branches (maybe not v11).

			regards, tom lane