From: Tom Lane <tgl@sss.pgh.pa.us>
To: Haritabh Gupta <haritabh1992@gmail.com>
cc: pgsql-hackers@lists.postgresql.org, Florin Irion <irionr@gmail.com>,
        Tim Waizenegger <tim.waizenegger@enterprisedb.com>
Subject: Re: [PATCH] pg_get_domain_ddl: DDL reconstruction function for CREATE DOMAIN statement
In-reply-to: <177145861697.626.9698606909114409697.pgcf@coridan.postgresql.org>
References: <CAPgqM1V4LW2qiDLPsusb7s0kYbSDJjH5Tt+-ZzVmPU7xV0TJNQ@mail.gmail.com> <CA+HEvJBTeS7gBw1sm7CeiWqGff5rcxrz6fzxVqNEnqg+bqK37A@mail.gmail.com> <177145861697.626.9698606909114409697.pgcf@coridan.postgresql.org>
Comments: In-reply-to Haritabh Gupta <haritabh1992@gmail.com>
	message dated "Wed, 18 Feb 2026 23:50:16 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2291231.1771459819.1@sss.pgh.pa.us>
Date: Wed, 18 Feb 2026 19:10:19 -0500
Message-ID: <2291232.1771459819@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2291232.1771459819%40sss.pgh.pa.us>
Precedence: bulk

Haritabh Gupta <haritabh1992@gmail.com> writes:
> Thanks for addressing the comments. I tested v7 and found that 
> type modifiers (typmod) are lost in the base type output.

This report crystallized something that's been bothering me
about not only pg_get_domain_ddl() but all the similar patches
that are in the queue.  They are adding a large amount of new
code that will have to be kept in sync with behavior elsewhere,
and there is basically zero forcing function to ensure that
that happens.  Even the rather-overly-voluminous test cases
proposed for the functions cannot catch errors of omission,
especially not future errors of omission.

I don't really know what to do about this, but I don't like the
implementation approach that's being proposed.  I think it's
loading too much development effort and future maintenance effort
onto us in comparison to the expected benefit of having these
functions.

			regards, tom lane