From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: Alexander Lakhin <exclusion@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: race condition in pg_class
In-reply-to: <20240728165132.01.nmisch@google.com>
References: <20240512232923.aa.nmisch@google.com>
 <20240605181706.fe.nmisch@google.com>
 <CA+TgmobfMU5pdXP36D5iAwxV5WKE_vuDLtp_1QyH+H5jMMt21g@mail.gmail.com>
 <20240611024525.9f.nmisch@google.com> <20240614003549.c2.nmisch@google.com>
 <20240621212842.98.nmisch@google.com> <20240628051353.a0.nmisch@google.com>
 <e3fa725b-474c-c155-6a0d-5c97cbfbdc4a@gmail.com>
 <20240720112835.f5.nmisch@google.com> <2250943.1722181833@sss.pgh.pa.us>
 <20240728165132.01.nmisch@google.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Sun, 28 Jul 2024 09:51:32 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2292564.1722185975.1@sss.pgh.pa.us>
Date: Sun, 28 Jul 2024 12:59:35 -0400
Message-ID: <2292565.1722185975@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2292565.1722185975%40sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> On Sun, Jul 28, 2024 at 11:50:33AM -0400, Tom Lane wrote:
>> Is it time to worry yet?  If this were HEAD only, I'd not be too
>> concerned; but two of these three are on allegedly-stable branches.
>> And we have releases coming up fast.

> I don't know; neither decision feels terrible to me.

Yeah, same here.  Obviously, it'd be better to spend effort on getting
the bug fix committed than to spend effort on some cosmetic
workaround.

The fact that the failure is in the isolation tests not the core
regression tests reduces my level of concern somewhat about shipping
it this way.  I think that packagers typically run the core tests
not check-world during package verification, so they won't hit this.

			regards, tom lane