Message-ID: <22e756affaad88b77a52d67cb532ed2a544f2e36.camel@j-davis.com>
Subject: Re: Comments on Custom RMGRs
From: Jeff Davis <pgsql@j-davis.com>
To: Danil Anisimow <anisimow.d@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, PostgreSQL Hackers
	 <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: Fri, 29 Mar 2024 10:09:38 -0700
In-Reply-To: <CABm2Ma5Ww9M8DgFTCcASnMiPPVYU8cd_wGhHZ5YnoK5im6wT2g@mail.gmail.com>
References: 
	<CANbhV-E4pTWeF-DsdaGsOrjJNFWPaR+Dstjrnkqvf9JFFgOKKQ@mail.gmail.com>
	 <f781f8f198567cee9e3776487bab3e41a7b91b82.camel@j-davis.com>
	 <20220512034010.4oqa76pasrulkw32@alap3.anarazel.de>
	 <CANbhV-G7SfdRLR6r7sxY0uL=TRU0S=cxkWJGWyTdss3u8LFK=g@mail.gmail.com>
	 <20220512234207.pwwp6q33f72byet2@alap3.anarazel.de>
	 <CANbhV-FFgAFeNZ=qNc7Fr991Asym+sfj=R5hb02XeRE6067=hg@mail.gmail.com>
	 <CABm2Ma7v4=W-1vH=kiA4M352F=Nd-Nvd_QBZufJ6EMGsS7Q-_A@mail.gmail.com>
	 <0892cd00635c8bcd458de6d43d31cf61953da1b2.camel@j-davis.com>
	 <CABm2Ma5Hi9PU_wWP0f=YFu9aDDdeSdX2+JFDL_oDH-QHgexsgg@mail.gmail.com>
	 <727b0f3b48aec2a4f968bf11c6fa8ca6382b6cca.camel@j-davis.com>
	 <CABm2Ma6avU5hkk7dd+G2oRNJZJtLOT=Yzeq6fb0v2rf7_YYp7g@mail.gmail.com>
	 <beb9c43d6492ffc273d236e4b93270dfad035f2f.camel@j-davis.com>
	 <CABm2Ma5Ww9M8DgFTCcASnMiPPVYU8cd_wGhHZ5YnoK5im6wT2g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/22e756affaad88b77a52d67cb532ed2a544f2e36.camel%40j-davis.com>
Precedence: bulk

On Fri, 2024-03-29 at 18:20 +0700, Danil Anisimow wrote:
>=20
> In [rmgr_003.v3.patch] I added a phase argument to RmgrCheckpoint().
> Currently it is only called in two places: before and after
> CheckPointBuffers().

I am fine with this.

You've moved the discussion forward in two ways:

  1. Changes to pg_stat_statements to actually use the API; and
  2. The hook is called at multiple points.

Those at least partially address the concerns raised by Andres and
Robert. But given that there was pushback from multiple people on the
feature, I'd like to hear from at least one of them. It's very late in
the cycle so I'm not sure we'll get more feedback in time, though.

Regards,
	Jeff Davis