Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jCkkd-0002h5-JH for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Mar 2020 13:53:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jCkkc-0000u0-De for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Mar 2020 13:53:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jCkkc-0000tt-0D for pgsql-hackers@lists.postgresql.org; Fri, 13 Mar 2020 13:53:22 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jCkkY-0001sJ-P7 for pgsql-hackers@postgresql.org; Fri, 13 Mar 2020 13:53:21 +0000 Received: by mail-lj1-x243.google.com with SMTP id r7so10593674ljp.10 for ; Fri, 13 Mar 2020 06:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=JsHI3q+mo9vqBOP810c0RGwbimJ26ObmD5iiAaIxiSw=; b=VvrWBJR1AfY0axakgYl7CHFDHJEMNXKJfWG4Nk2RlqM/RRb+qvEOCnGa0l24EdYaGO ujAzA4WwSP+7b5CdirHZyVRAe4W4YAAxrwAnjospf7rTTBhY2Ocpw1OGMo0iL0k4X5No M/MkW9dZNxrj4gMKATQRBc7qU3AGOvsTLIwciVeR5SuwRhBNeviHgPup+k0wNutAt2+z wXn0Fn6X56wPXpA0RlHQAxK/GCxrUJxXPWq7NUUkD8iNr0GcebJeA6cUh8gZmZrCd5M8 J0E9HEvG6v70x8+I6ncSgpIUKoHe645Y+TdA4z89eoG9snsYNcNBbC03PJeo8IHp5pXj mL/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=JsHI3q+mo9vqBOP810c0RGwbimJ26ObmD5iiAaIxiSw=; b=WVbpst/mbrDAmRBzqmzQi9W5UcB8tpoSN62wsNeDT7WuqUGBdsx0bpRL2+gAxXxI9z TH77wHViQ5mNVz2F3vj1QbRv/tl2Kkji2vO6t6zgF27cz+QAThtU+gkKtZ/OB4xeWuxJ QVZ1iQJFusPNp9W8Vs7pJwg42qeeHPTtN2ptdUcL8IxTuJ115YoTWPV65XPJsLM6B2np kAMWDNZUspFAjjNZ54sh9Pv6PNpQJjwxJ0c2LzrPjPfjcKdRWaK2mjkgT53mp3WZ47n/ mjLvYU5OB9XUQB8w4ZsFZKIgsjxSBunlvjfZSQH3GRU/s0fphA2fH4kwZUqoGtCvx6O1 xfSw== X-Gm-Message-State: ANhLgQ21cJTWjhKq6r8cYP6a1UE1iCZjY1vHs/iRZOG8nCPZNLSDvXQ+ Rlom4XlCSIM8rxggpxOYWeAIhkNhWXtJQi3xQykSF0I3JYfiEaUKg5Yy+yhD6Wi04WeSLhjlk5N cyU93r0Xz3FvVc8oN9f3A2Ar3n9ceBVbM4XKm6TywsWBhsBkjQ5m0FTl6HnLLZrZrumCmK7MOoO VV/CJDRTvqp3RMmGiVnIhj4yy/VPdcvg== X-Google-Smtp-Source: ADFU+vs9+EAx2pnQTOnEIoEqPTau9LxHcXU9xbNSPCwzg52/jynVdKebpMrPx2EiYuL6JQufmiLW9Q== X-Received: by 2002:a2e:9cc1:: with SMTP id g1mr8566705ljj.152.1584107595440; Fri, 13 Mar 2020 06:53:15 -0700 (PDT) Received: from localhost.localdomain ([157.33.236.190]) by smtp.gmail.com with ESMTPSA id w3sm22077575lfe.9.2020.03.13.06.53.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2020 06:53:14 -0700 (PDT) Subject: Re: backup manifests From: tushar To: Robert Haas Cc: Rajkumar Raghuwanshi , Suraj Kharage , Rushabh Lathia , Tels , David Steele , Andrew Dunstan , PostgreSQL Hackers , Jeevan Chalke , vignesh C References: <8d81bcd9-fa06-a8a2-10e2-8368580e8e4f@enterprisedb.com> <951f68f6-734d-3473-631d-dc84efac41bd@enterprisedb.com> <73e82c3f-5914-8c01-95b1-d03fbf1ad000@enterprisedb.com> <08fb5011-091a-0590-9ca6-01449a4c8779@enterprisedb.com> <3d2b645c-b373-7946-8b33-f1fd879c368d@enterprisedb.com> Message-ID: <22efd17f-e647-2b23-c5d4-350a24e4625b@enterprisedb.com> Date: Fri, 13 Mar 2020 19:23:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------B442BBFAD65ACAA3541D1534" Content-Language: en-US X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------B442BBFAD65ACAA3541D1534 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 3/12/20 8:16 PM, tushar wrote: >> Seems like expected behavior to me. We could consider providing a more >> descriptive error message, but there's now way for it to work. > > Right , Error message need to be more user friendly . One scenario which i feel - should error out  even if  -s option is specified. create  base  backup directory ( ./pg_basebackup data1) Connect to root user and take out  the permission from pg_hba.conf file ( chmod 004 pg_hba.conf) run pg_validatebackup - [centos@tushar-ldap-docker bin]$ ./pg_validatebackup data1 pg_validatebackup: error: could not open file "pg_hba.conf": Permission denied run pg_validatebackup  with switch -s [centos@tushar-ldap-docker bin]$ ./pg_validatebackup data1 -s pg_validatebackup: backup successfully verified here file is not accessible so i think - it should throw you an error ( the same above one) instead of   blindly skipping it. -- regards,tushar EnterpriseDB https://www.enterprisedb.com/ The Enterprise PostgreSQL Company --------------B442BBFAD65ACAA3541D1534 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
On 3/12/20 8:16 PM, tushar wrote:
Seems like expected behavior to me. We could consider providing a more
descriptive error message, but there's now way for it to work.

Right , Error message need to be more user friendly .

One scenario which i feel - should error out  even if  -s option is specified.

create  base  backup directory ( ./pg_basebackup data1)
Connect to root user and take out  the permission from pg_hba.conf file ( chmod 004 pg_hba.conf)

run pg_validatebackup -

[centos@tushar-ldap-docker bin]$ ./pg_validatebackup data1
pg_validatebackup: error: could not open file "pg_hba.conf": Permission denied

run pg_validatebackup  with switch -s

[centos@tushar-ldap-docker bin]$ ./pg_validatebackup data1 -s
pg_validatebackup: backup successfully verified

here file is not accessible so i think - it should throw you an error ( the same above one) instead of   blindly skipping it.  

-- 
regards,tushar
EnterpriseDB  https://www.enterprisedb.com/
The Enterprise PostgreSQL Company
--------------B442BBFAD65ACAA3541D1534--